Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAuthn] Update getClientCapabilities to use record instead of maplike #22373

Commits on Jan 13, 2024

  1. [WebAuthn] Update getClientCapabilities to use record instead of maplike

    rdar://120442670
    https://bugs.webkit.org/show_bug.cgi?id=267068
    
    Reviewed by Brent Fulgham.
    
    The spec has changed such that getClientCapabilities needs to return a record
    instead of a maplike. This patch makes that change. For more context, see the
    change at w3c/webauthn#1923.
    
    * Source/WebCore/DerivedSources-input.xcfilelist:
    * Source/WebCore/DerivedSources-output.xcfilelist:
    * Source/WebCore/DerivedSources.make:
    * Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:
    (WebCore::AuthenticatorCoordinator::getClientCapabilities const):
    * Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.h:
    * Source/WebCore/Modules/webauthn/AuthenticatorCoordinatorClient.h:
    * Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp:
    (WebCore::PublicKeyCredential::getClientCapabilities):
    * Source/WebCore/Modules/webauthn/PublicKeyCredential.h:
    * Source/WebCore/Modules/webauthn/PublicKeyCredential.idl:
    * Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.cpp: Removed.
    * Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.h: Removed.
    * Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.idl: Removed.
    * Source/WebCore/Sources.txt:
    * Source/WebCore/WebCore.xcodeproj/project.pbxproj:
    * Source/WebKit/Scripts/webkit/messages.py:
    (class_template_headers):
    * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
    * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
    * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
    
    Canonical link: https://commits.webkit.org/272998@main
    Pascoe committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    e595d21 View commit details
    Browse the repository at this point in the history