Fix IPC::Connection::sendOutputMessage(IPC::UnixMessage&) Syscall param sendmsg(msg.msg_iov[2]) points to uninitialised byte(s) #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujii
reviewed
Jul 10, 2022
jameshilliard
force-pushed
the
eng/IPCConnectionsendOutputMessageIPCUnixMessage-Syscall-param-sendmsgmsg-msg_iov2-points-to-uninitialised-bytes
branch
from
62c1e76
to
4f8abf1
Compare
jameshilliard
commented
Jul 10, 2022
| @@ -52,7 +52,7 @@ class UpdateInfo { | |||
|
|
|||
| // The size of the web view. | |||
| WebCore::IntSize viewSize; | |||
| float deviceScaleFactor; | |||
| float deviceScaleFactor { 0 }; | |||
There was a problem hiding this comment.
Is this not correct?
There was a problem hiding this comment.
Normally we'd initialize a scale factor to 1, not 0.
There was a problem hiding this comment.
Should I change that in a new PR? I thought this was getting set elsewhere if used and just needed to be initialized to anything.
…am sendmsg(msg.msg_iov[2]) points to uninitialised byte(s) https://bugs.webkit.org/show_bug.cgi?id=242518 Reviewed by Fujii Hironori. Initialize deviceScaleFactor and updateScaleFactor so that we don't try to encode uninitialized memory. * Source/WebKit/Shared/UpdateInfo.h: Canonical link: https://commits.webkit.org/252330@main
webkit-early-warning-system
force-pushed
the
eng/IPCConnectionsendOutputMessageIPCUnixMessage-Syscall-param-sendmsgmsg-msg_iov2-points-to-uninitialised-bytes
branch
from
4f8abf1
to
f4367f2
Compare
|
Committed 252330@main (f4367f2): https://commits.webkit.org/252330@main Reviewed commits have been landed. Closing PR #2273 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
jameshilliard
deleted the
eng/IPCConnectionsendOutputMessageIPCUnixMessage-Syscall-param-sendmsgmsg-msg_iov2-points-to-uninitialised-bytes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f4367f2