Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPC::Connection::sendOutputMessage(IPC::UnixMessage&) Syscall param sendmsg(msg.msg_iov[2]) points to uninitialised byte(s) #2273

Merged
merged 1 commit into from Jul 10, 2022
Merged

Fix IPC::Connection::sendOutputMessage(IPC::UnixMessage&) Syscall param sendmsg(msg.msg_iov[2]) points to uninitialised byte(s) #2273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/WebKit/Shared/UpdateInfo.h
View file
Open in desktop
Expand Up @@ -52,7 +52,7 @@ class UpdateInfo {

// The size of the web view.
WebCore::IntSize viewSize;
float deviceScaleFactor;
float deviceScaleFactor { 0 };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we'd initialize a scale factor to 1, not 0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change that in a new PR? I thought this was getting set elsewhere if used and just needed to be initialized to anything.


// The rect and delta to be scrolled.
WebCore::IntRect scrollRect;
Expand All @@ -65,7 +65,7 @@ class UpdateInfo {
Vector<WebCore::IntRect> updateRects;

// The page scale factor used to render this update.
float updateScaleFactor;
float updateScaleFactor { 0 };

// The handle of the shareable bitmap containing the updates. Will be null if there are no updates.
ShareableBitmap::Handle bitmapHandle;
Expand Down