-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename VideoFullscreenInterfaceAVKit to VideoFullscreenInterfaceIOS #23071
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
danae404:eng/Rename-VideoFullscreenInterfaceAVKit-to-VideoFullscreenInterfaceIOS
Jan 23, 2024
Merged
Rename VideoFullscreenInterfaceAVKit to VideoFullscreenInterfaceIOS #23071
webkit-commit-queue
merged 1 commit into
WebKit:main
from
danae404:eng/Rename-VideoFullscreenInterfaceAVKit-to-VideoFullscreenInterfaceIOS
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash b82157c) |
aestes
approved these changes
Jan 22, 2024
Please include a radar link instead of "Include a Radar link (OOPS!)." |
b82157c
to
cbe6e28
Compare
EWS run on previous version of this PR (hash cbe6e28) |
cbe6e28
to
8b671a6
Compare
EWS run on current version of this PR (hash 8b671a6) |
https://bugs.webkit.org/show_bug.cgi?id=267884 rdar://121399424 Reviewed by Andy Estes. Rename VideoFullscreenInterfaceAVKit to VideoFullscreenInterfaceIOS for future refactoring. * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/html/HTMLMediaElement.cpp: * Source/WebCore/platform/graphics/PlatformVideoFullscreenInterface.h: * Source/WebCore/platform/ios/VideoFullscreenInterfaceIOS.h: Renamed from Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h. * Source/WebCore/platform/ios/VideoFullscreenInterfaceIOS.mm: Renamed from Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm. (clearUIColor): (boolString): (-[WebAVPlayerViewControllerDelegate fullscreenInterface]): (-[WebAVPlayerViewControllerDelegate setFullscreenInterface:]): (-[WebAVPlayerViewControllerDelegate playerViewControllerWillStartPictureInPicture:]): (-[WebAVPlayerViewControllerDelegate playerViewControllerDidStartPictureInPicture:]): (-[WebAVPlayerViewControllerDelegate playerViewController:failedToStartPictureInPictureWithError:]): (-[WebAVPlayerViewControllerDelegate playerViewControllerWillStopPictureInPicture:]): (-[WebAVPlayerViewControllerDelegate playerViewControllerDidStopPictureInPicture:]): (-[WebAVPlayerViewControllerDelegate playerViewControllerShouldAutomaticallyDismissAtPictureInPictureStart:]): (convertToExitFullScreenReason): (-[WebAVPlayerViewControllerDelegate playerViewController:shouldExitFullScreenWithReason:]): (-[WebAVPlayerViewControllerDelegate playerViewController:restoreUserInterfaceForPictureInPictureStopWithCompletionHandler:]): (-[WebAVPlayerViewControllerDelegate playerViewControllerShouldStartPictureInPictureFromInlineWhenEnteringBackground:]): (-[WebAVPlayerViewControllerDelegate pictureInPictureControllerWillStartPictureInPicture:]): (-[WebAVPlayerViewControllerDelegate pictureInPictureControllerDidStartPictureInPicture:]): (-[WebAVPlayerViewControllerDelegate pictureInPictureController:failedToStartPictureInPictureWithError:]): (-[WebAVPlayerViewControllerDelegate pictureInPictureControllerWillStopPictureInPicture:]): (-[WebAVPlayerViewControllerDelegate pictureInPictureControllerDidStopPictureInPicture:]): (-[WebAVPlayerViewControllerDelegate pictureInPictureController:restoreUserInterfaceForPictureInPictureStopWithCompletionHandler:]): (WebAVPictureInPictureContentViewController_initWithController): (WebAVPictureInPictureContentViewController_controller): (WebAVPictureInPictureContentViewController_playerLayer): (WebAVPictureInPictureContentViewController_setPlayerLayer): (WebAVPictureInPictureContentViewController_viewWillLayoutSubviews): (WebAVPictureInPictureContentViewController_dealloc): (allocWebAVPictureInPictureContentViewControllerInstance): (-[WebAVPlayerViewController initWithFullscreenInterface:]): (-[WebAVPlayerViewController configurePlayerViewControllerWithFullscreenInterface:]): (-[WebAVPlayerViewController dealloc]): (-[WebAVPlayerViewController playerViewControllerShouldHandleDoneButtonTap:]): (-[WebAVPlayerViewController setWebKitOverrideRouteSharingPolicy:routingContextUID:]): (-[WebAVPlayerViewController enterFullScreenAnimated:completionHandler:]): (-[WebAVPlayerViewController exitFullScreenAnimated:completionHandler:]): (-[WebAVPlayerViewController observeValueForKeyPath:ofObject:change:context:]): (-[WebAVPlayerViewController initObserver]): (-[WebAVPlayerViewController removeObserver]): (-[WebAVPlayerViewController MY_NO_RETURN]): (-[WebAVPlayerViewController isPictureInPicturePossible]): (-[WebAVPlayerViewController isPictureInPictureActive]): (-[WebAVPlayerViewController pictureInPictureActive]): (-[WebAVPlayerViewController pictureInPictureWasStartedWhenEnteringBackground]): (-[WebAVPlayerViewController view]): (-[WebAVPlayerViewController flashPlaybackControlsWithDuration:]): (-[WebAVPlayerViewController showsPlaybackControls]): (-[WebAVPlayerViewController setShowsPlaybackControls:]): (-[WebAVPlayerViewController setAllowsPictureInPicturePlayback:]): (-[WebAVPlayerViewController setDelegate:]): (-[WebAVPlayerViewController setPlayerController:]): (-[WebAVPlayerViewController avPlayerViewController]): (-[WebAVPlayerViewController removeFromParentViewController]): (-[WebAVPlayerViewController logIdentifier]): (-[WebAVPlayerViewController loggerPtr]): (-[WebAVPlayerViewController logChannel]): (VideoFullscreenInterfaceIOS::create): (VideoFullscreenInterfaceIOS::VideoFullscreenInterfaceIOS): (VideoFullscreenInterfaceIOS::~VideoFullscreenInterfaceIOS): (VideoFullscreenInterfaceIOS::playerController const): (VideoFullscreenInterfaceIOS::avPlayerViewController const): (VideoFullscreenInterfaceIOS::setVideoPresentationModel): (VideoFullscreenInterfaceIOS::hasVideoChanged): (VideoFullscreenInterfaceIOS::videoDimensionsChanged): (VideoFullscreenInterfaceIOS::externalPlaybackChanged): (VideoFullscreenInterfaceIOS::pictureInPictureWasStartedWhenEnteringBackground const): (fallbackViewController): (VideoFullscreenInterfaceIOS::presentingViewController): (VideoFullscreenInterfaceIOS::applicationDidBecomeActive): (VideoFullscreenInterfaceIOS::setupFullscreen): (VideoFullscreenInterfaceIOS::enterFullscreen): (VideoFullscreenInterfaceIOS::exitFullscreen): (VideoFullscreenInterfaceIOS::exitFullscreenWithoutAnimationToMode): (VideoFullscreenInterfaceIOS::cleanupFullscreen): (VideoFullscreenInterfaceIOS::invalidate): (VideoFullscreenInterfaceIOS::setPlayerIdentifier): (VideoFullscreenInterfaceIOS::requestHideAndExitFullscreen): (VideoFullscreenInterfaceIOS::preparedToReturnToInline): (VideoFullscreenInterfaceIOS::preparedToExitFullscreen): (VideoFullscreenInterfaceIOS::mayAutomaticallyShowVideoPictureInPicture const): (VideoFullscreenInterfaceIOS::prepareForPictureInPictureStop): (VideoFullscreenInterfaceIOS::willStartPictureInPicture): (VideoFullscreenInterfaceIOS::didStartPictureInPicture): (VideoFullscreenInterfaceIOS::failedToStartPictureInPicture): (VideoFullscreenInterfaceIOS::willStopPictureInPicture): (VideoFullscreenInterfaceIOS::didStopPictureInPicture): (VideoFullscreenInterfaceIOS::prepareForPictureInPictureStopWithCompletionHandler): (VideoFullscreenInterfaceIOS::shouldExitFullscreenWithReason): (VideoFullscreenInterfaceIOS::setHasVideoContentLayer): (VideoFullscreenInterfaceIOS::setInlineRect): (VideoFullscreenInterfaceIOS::doSetup): (VideoFullscreenInterfaceIOS::preparedToReturnToStandby): (VideoFullscreenInterfaceIOS::finalizeSetup): (VideoFullscreenInterfaceIOS::doEnterFullscreen): (VideoFullscreenInterfaceIOS::doExitFullscreen): (VideoFullscreenInterfaceIOS::exitFullscreenHandler): (VideoFullscreenInterfaceIOS::enterFullscreenHandler): (VideoFullscreenInterfaceIOS::returnToStandby): (VideoFullscreenInterfaceIOS::watchdogTimerFired): (VideoFullscreenInterfaceIOS::setMode): (VideoFullscreenInterfaceIOS::clearMode): (VideoFullscreenInterfaceIOS::isPlayingVideoInEnhancedFullscreen const): (VideoFullscreenInterfaceIOS::logIdentifier const): (VideoFullscreenInterfaceIOS::loggerPtr const): (VideoFullscreenInterfaceIOS::logChannel const): (WebCore::setSupportsPictureInPicture): (WebCore::supportsPictureInPicture): * Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm: (VideoFullscreenControllerContext::setUpFullscreen): * Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: Canonical link: https://commits.webkit.org/273363@main
8b671a6
to
78ed1f1
Compare
Committed 273363@main (78ed1f1): https://commits.webkit.org/273363@main Reviewed commits have been landed. Closing PR #23071 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
78ed1f1
8b671a6