Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DigitalCredential's response attribute was renamed to data #23288

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Jan 26, 2024

d686b02

DigitalCredential's response attribute was renamed to data
https://bugs.webkit.org/show_bug.cgi?id=268139
rdar://121639016

Reviewed by Tim Nguyen.

Renames DigitalCredential's "response" attribute to "data" to match the spec.
WICG/digital-credentials#57

* Source/WebCore/Modules/credentialmanagement/DigitalCredential.cpp:
(WebCore::DigitalCredential::create):
(WebCore::DigitalCredential::DigitalCredential):
* Source/WebCore/Modules/credentialmanagement/DigitalCredential.h:
(WebCore::DigitalCredential::data const):
(WebCore::DigitalCredential::response const): Deleted.
* Source/WebCore/Modules/credentialmanagement/DigitalCredential.idl:

Canonical link: https://commits.webkit.org/273595@main

a6677bf

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@marcoscaceres marcoscaceres self-assigned this Jan 26, 2024
@marcoscaceres marcoscaceres added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jan 26, 2024
@marcoscaceres marcoscaceres added the merge-queue Applied to send a pull request to merge-queue label Jan 27, 2024
https://bugs.webkit.org/show_bug.cgi?id=268139
rdar://121639016

Reviewed by Tim Nguyen.

Renames DigitalCredential's "response" attribute to "data" to match the spec.
WICG/digital-credentials#57

* Source/WebCore/Modules/credentialmanagement/DigitalCredential.cpp:
(WebCore::DigitalCredential::create):
(WebCore::DigitalCredential::DigitalCredential):
* Source/WebCore/Modules/credentialmanagement/DigitalCredential.h:
(WebCore::DigitalCredential::data const):
(WebCore::DigitalCredential::response const): Deleted.
* Source/WebCore/Modules/credentialmanagement/DigitalCredential.idl:

Canonical link: https://commits.webkit.org/273595@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/DigitalCredentials-response-attribute-was-renamed-to-data branch from a6677bf to d686b02 Compare January 27, 2024 05:00
@webkit-commit-queue
Copy link
Collaborator

Committed 273595@main (d686b02): https://commits.webkit.org/273595@main

Reviewed commits have been landed. Closing PR #23288 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d686b02 into WebKit:main Jan 27, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
4 participants