-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Update SPI headers for iOS 17.4 #23345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 23fd3cc) |
23fd3cc
to
82525b0
Compare
EWS run on current version of this PR (hash 82525b0) |
aproskuryakov
approved these changes
Feb 1, 2024
JonWBedard
approved these changes
Feb 1, 2024
82525b0
to
49a9f15
Compare
https://bugs.webkit.org/show_bug.cgi?id=268210 rdar://problem/121706323 Reviewed by Jonathan Bedard and Alexey Proskuryakov. Add platform flags for libxpc (which is API as of iOS 17.4+) and for other SPI that were promoted to API as part of the BrowserEngineKit introduction. Use them to avoid redeclaring things that are now publicly available. Additionally, write new BrowserEngineKit SPI declarations for symbols that are used in testing and by SPI clients of WebKit. * Source/WTF/wtf/PlatformHave.h: * Source/WTF/wtf/spi/cocoa/IOSurfaceSPI.h: * Source/WTF/wtf/spi/darwin/XPCSPI.h: * Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h: * Source/WebCore/PAL/pal/spi/ios/BrowserEngineKitSPI.h: * Source/WebKit/Platform/spi/ios/UIKitSPI.h: * Tools/TestRunnerShared/spi/UIKitSPIForTesting.h: Canonical link: https://commits.webkit.org/274016@main
49a9f15
to
98226f6
Compare
Committed 274016@main (98226f6): https://commits.webkit.org/274016@main Reviewed commits have been landed. Closing PR #23345 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Tools / Tests
Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
98226f6
82525b0