Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG title should have display: none as the default UA style rule. #23703

Merged
merged 1 commit into from
Feb 2, 2024
Merged

SVG title should have display: none as the default UA style rule. #23703

merged 1 commit into from
Feb 2, 2024

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Feb 2, 2024 •
edited by webkit-early-warning-system
Loading

@rniwa rniwa self-assigned this Feb 2, 2024
@rniwa rniwa added the SVG For bugs in the SVG implementation. label Feb 2, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 2, 2024 •
edited
Loading

EWS run on current version of this PR (hash c586224)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Feb 2, 2024
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Feb 2, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #11003.

@rniwa
SVG title should have display: none as the default UA style rule.
86863f4 
https://bugs.webkit.org/show_bug.cgi?id=268587

Reviewed by Cameron McCormack.

Added a UA style rule for SVG title element.

* Source/WebCore/css/svg.css:
(title):

Canonical link: https://commits.webkit.org/273991@main
@webkit-commit-queue
Copy link
Collaborator

Committed 273991@main (86863f4): https://commits.webkit.org/273991@main

Reviewed commits have been landed. Closing PR #23703 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 86863f4 into WebKit:main Feb 2, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 2, 2024
@rniwa rniwa deleted the fix268587-svg-title-display-none branch May 21, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heycam heycam heycam approved these changes

Assignees

@rniwa rniwa

Labels
SVG For bugs in the SVG implementation.
Projects
None yet
Milestone
No milestone
6 participants
@rniwa @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @heycam @Ahmad-S792