[UnifiedPDF] PDFPluginBase should notify the web page of selection changes #23755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
reviewed
Feb 2, 2024
|
EWS run on previous version of this PR (hash 3b74ce7)
|
cdumez
reviewed
Feb 2, 2024
smfr
approved these changes
Feb 2, 2024
|
EWS run on previous version of this PR (hash a3dd9df) |
|
EWS run on current version of this PR (hash d46739f)
|
…anges https://bugs.webkit.org/show_bug.cgi?id=268618 rdar://122179410 Reviewed by Simon Fraser. In anticipation of selection tracking support in UnifiedPDFPlugin, this patch factors out PDFPlugin::notifySelectionChanged into a common space. We also take the liberty to drop the PDFSelection argument to notifySelectionChanged, given that it was not being read or passed to the web page by the PDF plugin. Lastly, we add a WebFrame::protectedCoreLocalFrame getter to better abide by our smart pointer rules, where we protect both the objects on which we call non-trivial member functions, and parameters we pass to such functions. * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: (-[WKPDFLayerControllerDelegate pdfLayerController:didChangeSelection:]): (WebKit::PDFPlugin::notifySelectionChanged): Deleted. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::notifySelectionChanged): * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::protectedCoreLocalFrame const): * Source/WebKit/WebProcess/WebPage/WebFrame.h: Canonical link: https://commits.webkit.org/274005@main
webkit-commit-queue
force-pushed
the
eng/268618
branch
from
d46739f
to
749aa44
Compare
|
Committed 274005@main (749aa44): https://commits.webkit.org/274005@main Reviewed commits have been landed. Closing PR #23755 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
749aa44
d46739f
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🛠 watch-sim