-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merge-Queue] Add author to commit message #242
Closed
JonWBedard
wants to merge
1
commit into
WebKit:main
from
JonWBedard:eng/Merge-Queue-Add-author-to-commit-message
Closed
[Merge-Queue] Add author to commit message #242
JonWBedard
wants to merge
1
commit into
WebKit:main
from
JonWBedard:eng/Merge-Queue-Add-author-to-commit-message
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
Tools / Tests
Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
WebKit Nightly Build
merge-queue
Applied to send a pull request to merge-queue
and removed
merge-queue
Applied to send a pull request to merge-queue
labels
Apr 4, 2022
webkit-early-warning-system
added
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 5, 2022
JonWBedard
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 5, 2022
https://ews-build.webkit-uat.org/#/builders/85/builds/156 shows this change working |
aj062
approved these changes
Apr 5, 2022
Tools/CISupport/ews-build/steps.py
Outdated
|
||
def getResultSummary(self): | ||
if self.results == FAILURE: | ||
return {'step': 'Failed to add author'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message can be more descriptive. failed to add author, where?
JonWBedard
force-pushed
the
eng/Merge-Queue-Add-author-to-commit-message
branch
2 times, most recently
from
April 5, 2022 17:47
c3e03de
to
b105590
Compare
https://bugs.webkit.org/show_bug.cgi?id=238752 <rdar://problem/91254339> Reviewed by Aakash Jain. svn.webkit.org will attribute a change to a specific author if "Patch by" is in the commit message. * Tools/CISupport/ews-build/factories.py: (MergeQueueFactory.__init__): Add AddAuthorToCommitMessage step. * Tools/CISupport/ews-build/factories_unittest.py: (TestExpectedBuildSteps): Ditto. * Tools/CISupport/ews-build/master.cfg: Determine commit author from github.head.user.login. * Tools/CISupport/ews-build/steps.py: (AddAuthorToCommitMessage): (AddAuthorToCommitMessage.__init__): (AddAuthorToCommitMessage.author): Return commit author's name and email, falling back to the committers name and email if those cannot be determined. (AddAuthorToCommitMessage.start): Insert "Patch by" into commit message. (AddAuthorToCommitMessage.getResultSummary): (AddAuthorToCommitMessage.doStepIf): Only do step if the author can be determined. (AddAuthorToCommitMessage.hideStepIf): Hide step if skipped. * Tools/CISupport/ews-build/steps_unittest.py:
webkit-early-warning-system
force-pushed
the
eng/Merge-Queue-Add-author-to-commit-message
branch
from
April 5, 2022 17:57
b105590
to
2ac1aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Tools / Tests
Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1e8eb307daa055dde54e7c11f60d4153ac9bd325