Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASSERTION FAILED: !m_invoking in CustomElementQueue::add() on tv.youtube.com #2486

Merged
merged 1 commit into from Jul 17, 2022
Merged

ASSERTION FAILED: !m_invoking in CustomElementQueue::add() on tv.youtube.com #2486

merged 1 commit into from Jul 17, 2022

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Jul 16, 2022 •
edited by webkit-commit-queue

a0165ae

ASSERTION FAILED: !m_invoking in CustomElementQueue::add() on tv.youtube.com
https://bugs.webkit.org/show_bug.cgi?id=237977

Reviewed by Wenson Hsieh.

The assertion failure was caused by ARIA reflection attributes not having CEReactions.
Fixed the bug and filed a spec bug: w3c/aria#1767

* LayoutTests/fast/custom-elements/reactions-for-aria-attributes-expected.txt: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-attributes.html: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes-expected.txt: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html: Added.
* Source/WebCore/accessibility/AriaAttributes.idl:

Canonical link: https://commits.webkit.org/252552@main

@rniwa rniwa self-assigned this Jul 16, 2022
@rniwa rniwa added DOM For bugs specific to XML/HTML DOM elements (including parsing). WebKit Nightly Build labels Jul 16, 2022
@rniwa rniwa requested review from cdumez and mrego July 16, 2022 08:19
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jul 16, 2022
@rniwa rniwa mentioned this pull request Jul 16, 2022
Merged
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Jul 16, 2022
@rniwa rniwa changed the title ASSERTION FAILED: !m_invoking in CustomElementQueue::add() on tv.youtube.com REGRESSION (r238524): SVG textPath cannot be rendered when <text> element is referred by <use> element Jul 16, 2022
@rniwa rniwa added SVG For bugs in the SVG implementation. and removed DOM For bugs specific to XML/HTML DOM elements (including parsing). labels Jul 16, 2022
@rniwa rniwa changed the title REGRESSION (r238524): SVG textPath cannot be rendered when <text> element is referred by <use> element ASSERTION FAILED: !m_invoking in CustomElementQueue::add() on tv.youtube.com Jul 16, 2022
@rniwa rniwa added DOM For bugs specific to XML/HTML DOM elements (including parsing). and removed SVG For bugs in the SVG implementation. labels Jul 16, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jul 16, 2022
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Jul 17, 2022
@whsieh whsieh self-requested a review July 17, 2022 21:43
@rniwa rniwa added the merge-queue Applied to send a pull request to merge-queue label Jul 17, 2022
@rniwa
ASSERTION FAILED: !m_invoking in CustomElementQueue::add() on tv.yout…
a0165ae 
…ube.com

https://bugs.webkit.org/show_bug.cgi?id=237977

Reviewed by Wenson Hsieh.

The assertion failure was caused by ARIA reflection attributes not having CEReactions.
Fixed the bug and filed a spec bug: w3c/aria#1767

* LayoutTests/fast/custom-elements/reactions-for-aria-attributes-expected.txt: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-attributes.html: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes-expected.txt: Added.
* LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html: Added.
* Source/WebCore/accessibility/AriaAttributes.idl:

Canonical link: https://commits.webkit.org/252552@main
@webkit-early-warning-system webkit-early-warning-system merged commit a0165ae into WebKit:main Jul 17, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 252552@main (a0165ae): https://commits.webkit.org/252552@main

Reviewed commits have been landed. Closing PR #2486 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 17, 2022
@rniwa rniwa deleted the fix237977 branch July 18, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

@cdumez cdumez Awaiting requested review from cdumez

@mrego mrego Awaiting requested review from mrego

Assignees

@rniwa rniwa

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
4 participants
@rniwa @webkit-commit-queue @whsieh @webkit-early-warning-system