Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IDREF element reflection #2151

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Implement IDREF element reflection #2151

merged 1 commit into from
Jul 19, 2022

Conversation

mrego
Copy link
Member

@mrego mrego commented Jul 7, 2022 •
edited by webkit-commit-queue
Loading

dcb5be2

Implement IDREF element reflection
https://bugs.webkit.org/show_bug.cgi?id=196843

Reviewed by Ryosuke Niwa.

Enable AriaReflectionForElementReferencesEnabled experimental flag by
default.

* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:

Canonical link: https://commits.webkit.org/252590@main

@mrego mrego self-assigned this Jul 7, 2022
@mrego mrego added DOM For bugs specific to XML/HTML DOM elements (including parsing). WebKit Nightly Build labels Jul 7, 2022
@rniwa
Copy link
Member

rniwa commented Jul 7, 2022

Do we pass all the tests?

@mrego
Copy link
Member Author

mrego commented Jul 7, 2022

Do we pass all the tests?

Yes we pass all WPT tests.

As commented on the bug, the HTML spec PR has been merged and the ARIA PR has been approved too.

@rniwa
Copy link
Member

rniwa commented Jul 7, 2022

Is it possible to wait until the end of July to land this?

@mrego
Copy link
Member Author

mrego commented Jul 7, 2022

Is it possible to wait until the end of July to land this?

Yes, sure. Just let me know when you think it might be a good moment to enable this.

@rniwa
Copy link
Member

rniwa commented Jul 7, 2022

Yeah, will do. Thank you!

@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jul 7, 2022
@cdumez
Copy link
Contributor

cdumez commented Jul 14, 2022

FYI, it is not a good time to enable the feature on trunk. However, there seem to be some failures on Mac EWS.

@rniwa
Copy link
Member

rniwa commented Jul 16, 2022

We should definitely fix #2486 before enabling this.

@mrego mrego removed the merging-blocked Applied to prevent a change from being merged label Jul 18, 2022
@mrego mrego force-pushed the enable-attribute-reflection-for-elements branch from 5e72650 to e11cbf3 Compare July 18, 2022 07:36
@mrego
Copy link
Member Author

mrego commented Jul 18, 2022

FYI, it is not a good time to enable the feature on trunk. However, there seem to be some failures on Mac EWS.

@cdumez did you mean "it is now a good time"?

The Mac EWS failures are gone after @rniwa's patch.

We should definitely fix #2486 before enabling this.

Thanks for fixing this.

@cdumez
Copy link
Contributor

cdumez commented Jul 18, 2022

FYI, it is not a good time to enable the feature on trunk. However, there seem to be some failures on Mac EWS.

@cdumez did you mean "it is now a good time"?

Yes I did! What a confusing typo, sorry.

rniwa
rniwa approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@rniwa
Copy link
Member

rniwa commented Jul 18, 2022

Thanks for waiting. We can enable it now.

@mrego mrego added the merge-queue Applied to send a pull request to merge-queue label Jul 19, 2022
@mrego
Implement IDREF element reflection
dcb5be2 
https://bugs.webkit.org/show_bug.cgi?id=196843

Reviewed by Ryosuke Niwa.

Enable AriaReflectionForElementReferencesEnabled experimental flag by
default.

* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:

Canonical link: https://commits.webkit.org/252590@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the enable-attribute-reflection-for-elements branch from e11cbf3 to dcb5be2 Compare July 19, 2022 05:26
@webkit-commit-queue
Copy link
Collaborator

Committed 252590@main (dcb5be2): https://commits.webkit.org/252590@main

Reviewed commits have been landed. Closing PR #2151 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit dcb5be2 into WebKit:main Jul 19, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 19, 2022
@mrego mrego deleted the enable-attribute-reflection-for-elements branch July 19, 2022 05:27
@rniwa
Copy link
Member

rniwa commented Sep 9, 2022

Actually, that may have been premature. As far as I can tell, this isn't hooked up with the actual accessibility object tree at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa approved these changes

@cdumez cdumez Awaiting requested review from cdumez

@cookiecrook cookiecrook Awaiting requested review from cookiecrook

Assignees

@mrego mrego

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrego @rniwa @cdumez @webkit-commit-queue @webkit-early-warning-system