--site-isolation isn't running tests in a cross-origin iframe
#25126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliewolfe
added
Tools / Tests
|
EWS run on previous version of this PR (hash c6dd252)
|
rreno
reviewed
Feb 27, 2024
| @@ -478,7 +478,7 @@ def _set_up_derived_options(port, options): | |||
| options.additional_platform_directory.insert(0, port.host.filesystem.join(host.scm().checkout_root, 'LayoutTests/platform/mac-gpup')) | |||
|
|
|||
| if port.port_name == "mac" and options.site_isolation: | |||
| options.self_compare_with_header = 'SiteIsolationEnabled=true runInCrossOriginIframe=true' | |||
| options.self_compare_with_header = 'SiteIsolationEnabled=true runInCrossOriginIFrame=true' | |||
There was a problem hiding this comment.
Can we just make this directive runInCrossOriginFrame (no I) so we don't make this typo again? I only worked on site isolation for about a week and I messed up the capitalization almost every time I tried to use the directive in an HTML comment.
There was a problem hiding this comment.
I should have probably made the fix myself but I thought I must be the only one making the mistake at the time.
There was a problem hiding this comment.
Yes, we should do that before merging this.
charliewolfe
removed
the
skip-ews
charliewolfe
force-pushed
the
eng/--site-isolation-isnt-running-tests-in-a-cross-origin-iframe
branch
from
c6dd252
to
67d618e
Compare
|
EWS run on current version of this PR (hash 67d618e) |
|
LGTM thanks for making that change to help avoid typos. (don't have r+ authority yet) |
achristensen07
approved these changes
Mar 8, 2024
achristensen07
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=270114 rdar://123646865 Reviewed by Alex Christensen. A typo was preventing it from being enabled. Most tests actually fail, so only enable a few for now. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): * Tools/Scripts/webkitpy/port/driver.py: (Driver.is_http_test): * Tools/Scripts/webkitpy/port/driver_unittest.py: * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): * Tools/WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): (WTR::TestOptions::keyTypeMapping): * Tools/WebKitTestRunner/TestOptions.h: (WTR::TestOptions::runInCrossOriginFrame const): (WTR::TestOptions::runInCrossOriginIFrame const): Deleted. Canonical link: https://commits.webkit.org/275837@main
webkit-commit-queue
force-pushed
the
eng/--site-isolation-isnt-running-tests-in-a-cross-origin-iframe
branch
from
67d618e
to
be13d89
Compare
|
Committed 275837@main (be13d89): https://commits.webkit.org/275837@main Reviewed commits have been landed. Closing PR #25126 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be13d89
67d618e