-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--site-isolation
isn't running tests in a cross-origin iframe
#25126
--site-isolation
isn't running tests in a cross-origin iframe
#25126
Conversation
EWS run on previous version of this PR (hash c6dd252)
|
@@ -478,7 +478,7 @@ def _set_up_derived_options(port, options): | |||
options.additional_platform_directory.insert(0, port.host.filesystem.join(host.scm().checkout_root, 'LayoutTests/platform/mac-gpup')) | |||
|
|||
if port.port_name == "mac" and options.site_isolation: | |||
options.self_compare_with_header = 'SiteIsolationEnabled=true runInCrossOriginIframe=true' | |||
options.self_compare_with_header = 'SiteIsolationEnabled=true runInCrossOriginIFrame=true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just make this directive runInCrossOriginFrame
(no I
) so we don't make this typo again? I only worked on site isolation for about a week and I messed up the capitalization almost every time I tried to use the directive in an HTML comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have probably made the fix myself but I thought I must be the only one making the mistake at the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should do that before merging this.
c6dd252
to
67d618e
Compare
EWS run on current version of this PR (hash 67d618e) |
LGTM thanks for making that change to help avoid typos. (don't have r+ authority yet) |
https://bugs.webkit.org/show_bug.cgi?id=270114 rdar://123646865 Reviewed by Alex Christensen. A typo was preventing it from being enabled. Most tests actually fail, so only enable a few for now. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): * Tools/Scripts/webkitpy/port/driver.py: (Driver.is_http_test): * Tools/Scripts/webkitpy/port/driver_unittest.py: * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): * Tools/WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): (WTR::TestOptions::keyTypeMapping): * Tools/WebKitTestRunner/TestOptions.h: (WTR::TestOptions::runInCrossOriginFrame const): (WTR::TestOptions::runInCrossOriginIFrame const): Deleted. Canonical link: https://commits.webkit.org/275837@main
67d618e
to
be13d89
Compare
Committed 275837@main (be13d89): https://commits.webkit.org/275837@main Reviewed commits have been landed. Closing PR #25126 and removing active labels. |
be13d89
67d618e