-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPE] WPE Platform: Opaque region support #25344
[WPE] WPE Platform: Opaque region support #25344
Conversation
EWS run on previous version of this PR (hash 015eb29)
|
015eb29
to
e4a11e3
Compare
EWS run on previous version of this PR (hash e4a11e3)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
e4a11e3
to
5777731
Compare
EWS run on current version of this PR (hash 5777731)
|
https://bugs.webkit.org/show_bug.cgi?id=267705 Reviewed by Alejandro G. Castro. Add API to set the opaque region on a WPEView and use it from WebKit to set the web view region as opaque when the background color is opaque. * Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp: (webkit_web_view_set_background_color): * Source/WebKit/WPEPlatform/CMakeLists.txt: * Source/WebKit/WPEPlatform/wpe/WPERectangle.cpp: Copied from Source/WebKit/WPEPlatform/wpe/wpe-platform.h. (wpe_rectangle_copy): (wpe_rectangle_free): * Source/WebKit/WPEPlatform/wpe/WPERectangle.h: Copied from Source/WebKit/WPEPlatform/wpe/wpe-platform.h. * Source/WebKit/WPEPlatform/wpe/WPEView.cpp: (wpe_view_set_opaque_rectangles): * Source/WebKit/WPEPlatform/wpe/WPEView.h: * Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp: (wpeViewWaylandConstructed): (wpeViewWaylandSetOpaqueRectangles): (wpe_view_wayland_class_init): * Source/WebKit/WPEPlatform/wpe/wpe-platform.h: Canonical link: https://commits.webkit.org/275684@main
5777731
to
6b96e27
Compare
Committed 275684@main (6b96e27): https://commits.webkit.org/275684@main Reviewed commits have been landed. Closing PR #25344 and removing active labels. |
6b96e27
5777731
🧪 wpe-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk2🧪 gtk-wk2🧪 mac-AS-debug-wk2🧪 api-gtk