Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreviewed, address Darin feedback on 275631@main #25428

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Unreviewed, address Darin feedback on 275631@main #25428

merged 1 commit into from
Mar 4, 2024

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Mar 4, 2024 •
edited by webkit-early-warning-system

@cdumez cdumez self-assigned this Mar 4, 2024
@cdumez cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Mar 4, 2024
@cdumez cdumez mentioned this pull request Mar 4, 2024
Merged
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 4, 2024 •
edited

EWS run on current version of this PR (hash 7ce855a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 gtk
✅ 🧪 api-ios   🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 api-gtk
  🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 4, 2024
@cdumez
Unreviewed, address Darin feedback on 275631@main
f75b94b 
https://bugs.webkit.org/show_bug.cgi?id=270452

* Source/WebKit/UIProcess/API/APINotificationProvider.h:
* Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.h:

Canonical link: https://commits.webkit.org/275640@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Unreviewed-address-Darin-feedback-on-275631main branch from 7ce855a to f75b94b Compare March 4, 2024 19:00
@webkit-commit-queue
Copy link
Collaborator

Committed 275640@main (f75b94b): https://commits.webkit.org/275640@main

Reviewed commits have been landed. Closing PR #25428 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f75b94b into WebKit:main Mar 4, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cdumez cdumez

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
3 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue