-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebDriver] Update imported WPT WebDriver tests #26004
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
lauromoura:eng/WebDriver-Update-imported-WPT-WebDriver-tests
Mar 19, 2024
Merged
[WebDriver] Update imported WPT WebDriver tests #26004
webkit-commit-queue
merged 1 commit into
WebKit:main
from
lauromoura:eng/WebDriver-Update-imported-WPT-WebDriver-tests
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on current version of this PR (hash 785ce86) |
carlosgcampos
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work here. Thanks!
https://bugs.webkit.org/show_bug.cgi?id=267835 Reviewed by Carlos Garcia Campos. Bump imported version to 097898330ea0 from late January. Upstream web-platform-tests/wpt#40910 changed WPT WebDriver tests to use HTTPS urls instead of HTTP. This led to tests using URLs provided by the local server to fail with unrecognized certificates. This commit forces the browser under test to use the test certificates instead of relying on the system ones. While this allows using the local HTTPS server, it has the drawback of ingnoring the system certificates, failing to access external websites if a test wants to (which does not seems to be the case now). Also rename the config `bind_hostname` to `bind_address` after web-platform-tests/wpt#9998 * Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py: (WebDriverW3CExecutor.__init__): Export variable for certificate setup (WebDriverW3CExecutor._runner): Add new timeout_multipler key as in WTP 1a44d85 * Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py: (WebDriverW3CWebServer.start): Store information about certificates being used in the current test run. (WebDriverW3CWebServer.cacert_pem_file): Export the certificates location * WebDriverTests/TestExpectations.json: Update classic and new bidi expectations * WebDriverTests/imported/w3c/config.json: Rename bind_hostname to bind_address key * WebDriverTests/imported/w3c/importer.json: Update imported WPT hash * WebDriverTests/imported/w3c/tools/: Bump imported code * WebDriverTests/imported/w3c/webdriver/: Bump imported code Canonical link: https://commits.webkit.org/276326@main
785ce86
to
1f76c86
Compare
Committed 276326@main (1f76c86): https://commits.webkit.org/276326@main Reviewed commits have been landed. Closing PR #26004 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1f76c86
785ce86