Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebDriver] Update imported WPT WebDriver tests #26004

Conversation

lauromoura
Copy link
Contributor

@lauromoura lauromoura commented Mar 16, 2024

1f76c86

[WebDriver] Update imported WPT WebDriver tests
https://bugs.webkit.org/show_bug.cgi?id=267835

Reviewed by Carlos Garcia Campos.

Bump imported version to 097898330ea0 from late January.

Upstream web-platform-tests/wpt#40910 changed
WPT WebDriver tests to use HTTPS urls instead of HTTP. This led to tests
using URLs provided by the local server to fail with unrecognized
certificates.

This commit forces the browser under test to use the test certificates
instead of relying on the system ones. While this allows using the local
HTTPS server, it has the drawback of ingnoring the system certificates,
failing to access external websites if a test wants to (which does not
seems to be the case now).

Also rename the config `bind_hostname` to `bind_address` after
web-platform-tests/wpt#9998

* Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
(WebDriverW3CExecutor.__init__): Export variable for certificate setup
(WebDriverW3CExecutor._runner): Add new timeout_multipler key as in WTP 1a44d855cb
* Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
(WebDriverW3CWebServer.start): Store information about certificates
being used in the current test run.
(WebDriverW3CWebServer.cacert_pem_file): Export the certificates
location
* WebDriverTests/TestExpectations.json: Update classic and new bidi
  expectations
* WebDriverTests/imported/w3c/config.json: Rename bind_hostname to
  bind_address key
* WebDriverTests/imported/w3c/importer.json: Update imported WPT hash
* WebDriverTests/imported/w3c/tools/: Bump imported code
* WebDriverTests/imported/w3c/webdriver/: Bump imported code

Canonical link: https://commits.webkit.org/276326@main

785ce86

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ webkitpy βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-skia
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@lauromoura lauromoura self-assigned this Mar 16, 2024
@lauromoura lauromoura added the WebDriver Bugs in WebDriver label Mar 16, 2024
Copy link
Contributor

@carlosgcampos carlosgcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work here. Thanks!

@lauromoura lauromoura added the merge-queue Applied to send a pull request to merge-queue label Mar 19, 2024
https://bugs.webkit.org/show_bug.cgi?id=267835

Reviewed by Carlos Garcia Campos.

Bump imported version to 097898330ea0 from late January.

Upstream web-platform-tests/wpt#40910 changed
WPT WebDriver tests to use HTTPS urls instead of HTTP. This led to tests
using URLs provided by the local server to fail with unrecognized
certificates.

This commit forces the browser under test to use the test certificates
instead of relying on the system ones. While this allows using the local
HTTPS server, it has the drawback of ingnoring the system certificates,
failing to access external websites if a test wants to (which does not
seems to be the case now).

Also rename the config `bind_hostname` to `bind_address` after
web-platform-tests/wpt#9998

* Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
(WebDriverW3CExecutor.__init__): Export variable for certificate setup
(WebDriverW3CExecutor._runner): Add new timeout_multipler key as in WTP 1a44d85
* Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
(WebDriverW3CWebServer.start): Store information about certificates
being used in the current test run.
(WebDriverW3CWebServer.cacert_pem_file): Export the certificates
location
* WebDriverTests/TestExpectations.json: Update classic and new bidi
  expectations
* WebDriverTests/imported/w3c/config.json: Rename bind_hostname to
  bind_address key
* WebDriverTests/imported/w3c/importer.json: Update imported WPT hash
* WebDriverTests/imported/w3c/tools/: Bump imported code
* WebDriverTests/imported/w3c/webdriver/: Bump imported code

Canonical link: https://commits.webkit.org/276326@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebDriver-Update-imported-WPT-WebDriver-tests branch from 785ce86 to 1f76c86 Compare March 19, 2024 03:29
@webkit-commit-queue
Copy link
Collaborator

Committed 276326@main (1f76c86): https://commits.webkit.org/276326@main

Reviewed commits have been landed. Closing PR #26004 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1f76c86 into WebKit:main Mar 19, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebDriver Bugs in WebDriver
Projects
None yet
4 participants