Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bind_hostname to bind_address #9998

Merged
merged 2 commits into from Mar 14, 2018

Conversation

Projects
None yet
4 participants
@gsnedders
Copy link
Contributor

gsnedders commented Mar 13, 2018

This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Mar 13, 2018

@wpt-pr-bot wpt-pr-bot requested a review from jgraham Mar 13, 2018

@@ -8,7 +8,7 @@
"wss":["auto"]},
"check_subdomains": true,
"log_level":"debug",
"bind_hostname": true,
"bind_address": true,

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 13, 2018

Author Contributor

Do we need to change anything so old config.json files still work? (These are only supported with wpt serve and not wpt run, AFAIK.)

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 13, 2018

Build PASSED

Started: 2018-03-13 17:04:33
Finished: 2018-03-13 17:21:08

View more information about this build on:

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Mar 13, 2018

Review status: 0 of 8 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


config.default.json, line 11 at r1 (raw file):

Previously, gsnedders (Geoffrey Sneddon) wrote…

Do we need to change anything so old config.json files still work? (These are only supported with wpt serve and not wpt run, AFAIK.)

Yes, I think explicit support for the old value with a warningn would be a good idea.


Comments from Reviewable

gsnedders added some commits Feb 8, 2018

Rename bind_hostname to bind_address
This keeps on confusing me; hopefully this will stop that.

@gsnedders gsnedders force-pushed the gsnedders:bind_address branch from 92a14a0 to d26c242 Mar 13, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Mar 13, 2018

Review status: 0 of 8 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


config.default.json, line 11 at r1 (raw file):

Previously, jgraham wrote…

Yes, I think explicit support for the old value with a warningn would be a good idea.

Done.


Comments from Reviewable

@gsnedders gsnedders merged commit ec54ac4 into web-platform-tests:master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the gsnedders:bind_address branch Mar 14, 2018

aarongable pushed a commit to chromium/chromium that referenced this pull request Apr 5, 2018

Roll in new version of WPT tools
This roll is mainly to include
web-platform-tests/wpt#10323, which fixes a bug
that `wpt manifest` would fail when the local manifest is invalid.

wpt.config.json is changed to accomodate:
web-platform-tests/wpt#9998
web-platform-tests/wpt#10078

Bug: 822041
Change-Id: I074afd90e32db299fc6f58b870f9b72576fab225
Reviewed-on: https://chromium-review.googlesource.com/997764
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548584}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.