Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bind_hostname to bind_address #9998

Merged
merged 2 commits into from
Mar 14, 2018

Conversation

gsnedders
Copy link
Member

@gsnedders gsnedders commented Mar 13, 2018

This change is Reviewable

@@ -8,7 +8,7 @@
"wss":["auto"]},
"check_subdomains": true,
"log_level":"debug",
"bind_hostname": true,
"bind_address": true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change anything so old config.json files still work? (These are only supported with wpt serve and not wpt run, AFAIK.)

@w3c-bots
Copy link

w3c-bots commented Mar 13, 2018

Build PASSED

Started: 2018-03-13 17:04:33
Finished: 2018-03-13 17:21:08

View more information about this build on:

@jgraham
Copy link
Contributor

jgraham commented Mar 13, 2018

Review status: 0 of 8 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


config.default.json, line 11 at r1 (raw file):

Previously, gsnedders (Geoffrey Sneddon) wrote…

Do we need to change anything so old config.json files still work? (These are only supported with wpt serve and not wpt run, AFAIK.)

Yes, I think explicit support for the old value with a warningn would be a good idea.


Comments from Reviewable

This keeps on confusing me; hopefully this will stop that.
@gsnedders
Copy link
Member Author

Review status: 0 of 8 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


config.default.json, line 11 at r1 (raw file):

Previously, jgraham wrote…

Yes, I think explicit support for the old value with a warningn would be a good idea.

Done.


Comments from Reviewable

@gsnedders gsnedders merged commit ec54ac4 into web-platform-tests:master Mar 14, 2018
@gsnedders gsnedders deleted the bind_address branch March 14, 2018 18:08
aarongable pushed a commit to chromium/chromium that referenced this pull request Apr 5, 2018
This roll is mainly to include
web-platform-tests/wpt#10323, which fixes a bug
that `wpt manifest` would fail when the local manifest is invalid.

wpt.config.json is changed to accomodate:
web-platform-tests/wpt#9998
web-platform-tests/wpt#10078

Bug: 822041
Change-Id: I074afd90e32db299fc6f58b870f9b72576fab225
Reviewed-on: https://chromium-review.googlesource.com/997764
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548584}
webkit-commit-queue pushed a commit to lauromoura/WebKit that referenced this pull request Mar 19, 2024
https://bugs.webkit.org/show_bug.cgi?id=267835

Reviewed by Carlos Garcia Campos.

Bump imported version to 097898330ea0 from late January.

Upstream web-platform-tests/wpt#40910 changed
WPT WebDriver tests to use HTTPS urls instead of HTTP. This led to tests
using URLs provided by the local server to fail with unrecognized
certificates.

This commit forces the browser under test to use the test certificates
instead of relying on the system ones. While this allows using the local
HTTPS server, it has the drawback of ingnoring the system certificates,
failing to access external websites if a test wants to (which does not
seems to be the case now).

Also rename the config `bind_hostname` to `bind_address` after
web-platform-tests/wpt#9998

* Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
(WebDriverW3CExecutor.__init__): Export variable for certificate setup
(WebDriverW3CExecutor._runner): Add new timeout_multipler key as in WTP 1a44d85
* Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
(WebDriverW3CWebServer.start): Store information about certificates
being used in the current test run.
(WebDriverW3CWebServer.cacert_pem_file): Export the certificates
location
* WebDriverTests/TestExpectations.json: Update classic and new bidi
  expectations
* WebDriverTests/imported/w3c/config.json: Rename bind_hostname to
  bind_address key
* WebDriverTests/imported/w3c/importer.json: Update imported WPT hash
* WebDriverTests/imported/w3c/tools/: Bump imported code
* WebDriverTests/imported/w3c/webdriver/: Bump imported code

Canonical link: https://commits.webkit.org/276326@main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants