Rename bind_hostname to bind_address #9998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnedders
commented
Mar 13, 2018
| @@ -8,7 +8,7 @@ | |||
| "wss":["auto"]}, | |||
| "check_subdomains": true, | |||
| "log_level":"debug", | |||
| "bind_hostname": true, | |||
| "bind_address": true, | |||
There was a problem hiding this comment.
Do we need to change anything so old config.json files still work? (These are only supported with wpt serve and not wpt run, AFAIK.)
Build PASSEDStarted: 2018-03-13 17:04:33 View more information about this build on: |
|
Review status: 0 of 8 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. config.default.json, line 11 at r1 (raw file): Previously, gsnedders (Geoffrey Sneddon) wrote…
Yes, I think explicit support for the old value with a warningn would be a good idea. Comments from Reviewable |
This keeps on confusing me; hopefully this will stop that.
|
Review status: 0 of 8 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending. config.default.json, line 11 at r1 (raw file): Previously, jgraham wrote…
Done. Comments from Reviewable |
jgraham
approved these changes
Mar 14, 2018
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 5, 2018
This roll is mainly to include web-platform-tests/wpt#10323, which fixes a bug that `wpt manifest` would fail when the local manifest is invalid. wpt.config.json is changed to accomodate: web-platform-tests/wpt#9998 web-platform-tests/wpt#10078 Bug: 822041 Change-Id: I074afd90e32db299fc6f58b870f9b72576fab225 Reviewed-on: https://chromium-review.googlesource.com/997764 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#548584}
webkit-commit-queue
pushed a commit
to lauromoura/WebKit
that referenced
this pull request
Mar 19, 2024
https://bugs.webkit.org/show_bug.cgi?id=267835 Reviewed by Carlos Garcia Campos. Bump imported version to 097898330ea0 from late January. Upstream web-platform-tests/wpt#40910 changed WPT WebDriver tests to use HTTPS urls instead of HTTP. This led to tests using URLs provided by the local server to fail with unrecognized certificates. This commit forces the browser under test to use the test certificates instead of relying on the system ones. While this allows using the local HTTPS server, it has the drawback of ingnoring the system certificates, failing to access external websites if a test wants to (which does not seems to be the case now). Also rename the config `bind_hostname` to `bind_address` after web-platform-tests/wpt#9998 * Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py: (WebDriverW3CExecutor.__init__): Export variable for certificate setup (WebDriverW3CExecutor._runner): Add new timeout_multipler key as in WTP 1a44d85 * Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py: (WebDriverW3CWebServer.start): Store information about certificates being used in the current test run. (WebDriverW3CWebServer.cacert_pem_file): Export the certificates location * WebDriverTests/TestExpectations.json: Update classic and new bidi expectations * WebDriverTests/imported/w3c/config.json: Rename bind_hostname to bind_address key * WebDriverTests/imported/w3c/importer.json: Update imported WPT hash * WebDriverTests/imported/w3c/tools/: Bump imported code * WebDriverTests/imported/w3c/webdriver/: Bump imported code Canonical link: https://commits.webkit.org/276326@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is