[JSC] Add operationIteratorNextTryFast operation #26232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on previous version of this PR (hash 60717cf) |
Constellation
force-pushed
the
eng/JSC-Add-operationIteratorNextTryFast-operation
branch
from
60717cf
to
433b634
Compare
|
EWS run on current version of this PR (hash 433b634) |
hyjorc1
reviewed
Mar 21, 2024
| JITSlowPathCall slowPathCall(this, tryFastFunction); | ||
| slowPathCall.call(); | ||
| Jump fastCase = branch32(NotEqual, GPRInfo::returnValueGPR2, TrustedImm32(static_cast<uint32_t>(IterationMode::Generic))); | ||
| #endif | ||
| doneCases.append(jump()); |
There was a problem hiding this comment.
So, iteratorNextTryFastImpl always returns IterationMode::FastArray. That's why no need for additional iteration mode check like before for the slowPathCall.call() path.
hyjorc1
reviewed
Mar 21, 2024
| callOperation(operationIteratorNextTryFast, argumentGPR0, argumentGPR1, argumentGPR2, argumentGPR3); | ||
| emitPutVirtualRegister(bytecode.m_done, returnValueGPR); | ||
| emitPutVirtualRegister(bytecode.m_value, returnValueGPR2); | ||
| doneCases.append(branchIfEmpty(JSValueRegs { returnValueGPR2 })); |
There was a problem hiding this comment.
Should it be branchIfNotEmpty? Since returnValueGPR2 is the next value.
There was a problem hiding this comment.
Oh, nvm we don't need to update the value profile if it's empty.
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=271367 rdar://125151326 Reviewed by Keith Miller. This function is very hot since it is invoked for each iteration run for fast arrays. Let's make it extremely optimized: use JITOperations instead of slow path calls. * Source/JavaScriptCore/jit/JITCall.cpp: (JSC::JIT::emit_op_iterator_next): * Source/JavaScriptCore/jit/JITOperations.cpp: (JSC::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/jit/JITOperations.h: Canonical link: https://commits.webkit.org/276577@main
webkit-commit-queue
force-pushed
the
eng/JSC-Add-operationIteratorNextTryFast-operation
branch
from
433b634
to
a50b786
Compare
|
Committed 276577@main (a50b786): https://commits.webkit.org/276577@main Reviewed commits have been landed. Closing PR #26232 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a50b786
433b634