-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move more ivars from WKWebViewConfiguration to API::PageConfiguration #26261
Move more ivars from WKWebViewConfiguration to API::PageConfiguration #26261
Conversation
EWS run on previous version of this PR (hash a95dbc9)
|
a95dbc9
to
355b010
Compare
EWS run on previous version of this PR (hash 355b010)
|
355b010
to
0058cda
Compare
EWS run on previous version of this PR (hash 0058cda)
|
} | ||
#endif | ||
|
||
} // API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually see closing namespace comments like } // namespace API
.
@@ -137,10 +133,6 @@ - (instancetype)init | |||
_allowsPictureInPictureMediaPlayback = YES; | |||
#endif | |||
|
|||
_allowsInlineMediaPlayback = !PAL::currentUserInterfaceIdiomIsSmallScreen(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#import <pal/system/ios/UserInterfaceIdiom.h>
can probably be removed from this file now.
0058cda
to
b279eb6
Compare
EWS run on previous version of this PR (hash b279eb6)
|
b279eb6
to
781cf7b
Compare
EWS run on current version of this PR (hash 781cf7b)
|
https://bugs.webkit.org/show_bug.cgi?id=271405 rdar://125186260 Reviewed by Charlie Wolfe. * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::inlineMediaPlaybackRequiresPlaysInlineAttribute const): (API::PageConfiguration::setInlineMediaPlaybackRequiresPlaysInlineAttribute): (API::PageConfiguration::allowsInlineMediaPlaybackAfterFullscreen const): (API::PageConfiguration::setAllowsInlineMediaPlaybackAfterFullscreen): (API::PageConfiguration::mediaDataLoadsAutomatically const): (API::PageConfiguration::setMediaDataLoadsAutomatically): (API::PageConfiguration::dragLiftDelay const): (API::PageConfiguration::setDragLiftDelay): (API::PageConfiguration::textInteractionGesturesEnabled const): (API::PageConfiguration::setTextInteractionGesturesEnabled): (API::PageConfiguration::longPressActionsEnabled const): (API::PageConfiguration::setLongPressActionsEnabled): (API::PageConfiguration::systemPreviewEnabled const): (API::PageConfiguration::setSystemPreviewEnabled): (API::PageConfiguration::shouldDecidePolicyBeforeLoadingQuickLookPreview const): (API::PageConfiguration::setShouldDecidePolicyBeforeLoadingQuickLookPreview): * Source/WebKit/UIProcess/API/Cocoa/APIPageConfigurationCocoa.mm: Added. (API::PageConfiguration::Data::defaultShouldDecidePolicyBeforeLoadingQuickLookPreview): (API::PageConfiguration::Data::defaultDragLiftDelay): * Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (toDragLiftDelay): (toWKDragLiftDelay): (fromWKDragLiftDelay): (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _inlineMediaPlaybackRequiresPlaysInlineAttribute]): (-[WKWebViewConfiguration _setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): (-[WKWebViewConfiguration _allowsInlineMediaPlaybackAfterFullscreen]): (-[WKWebViewConfiguration _setAllowsInlineMediaPlaybackAfterFullscreen:]): (-[WKWebViewConfiguration _dragLiftDelay]): (-[WKWebViewConfiguration _setDragLiftDelay:]): (-[WKWebViewConfiguration _longPressActionsEnabled]): (-[WKWebViewConfiguration _setLongPressActionsEnabled:]): (-[WKWebViewConfiguration _systemPreviewEnabled]): (-[WKWebViewConfiguration _setSystemPreviewEnabled:]): (-[WKWebViewConfiguration _shouldDecidePolicyBeforeLoadingQuickLookPreview]): (-[WKWebViewConfiguration _setShouldDecidePolicyBeforeLoadingQuickLookPreview:]): (-[WKWebViewConfiguration _mediaDataLoadsAutomatically]): (-[WKWebViewConfiguration _setMediaDataLoadsAutomatically:]): (-[WKWebViewConfiguration _textInteractionGesturesEnabled]): (-[WKWebViewConfiguration _setTextInteractionGesturesEnabled:]): (defaultShouldDecidePolicyBeforeLoadingQuickLookPreview): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/276517@main
781cf7b
to
b2db745
Compare
Committed 276517@main (b2db745): https://commits.webkit.org/276517@main Reviewed commits have been landed. Closing PR #26261 and removing active labels. |
b2db745
781cf7b
🧪 wpe-wk2🧪 api-mac🛠 tv-sim🛠 watch