Move more ivars from WKWebViewConfiguration to API::PageConfiguration #26261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
the
WebKit API
|
EWS run on previous version of this PR (hash a95dbc9)
|
achristensen07
force-pushed
the
eng/Move-more-ivars-from-WKWebViewConfiguration-to-APIPageConfiguration
branch
from
a95dbc9
to
355b010
Compare
|
EWS run on previous version of this PR (hash 355b010)
|
webkit-ews-buildbot
added
the
merging-blocked
achristensen07
removed
the
merging-blocked
achristensen07
force-pushed
the
eng/Move-more-ivars-from-WKWebViewConfiguration-to-APIPageConfiguration
branch
from
355b010
to
0058cda
Compare
|
EWS run on previous version of this PR (hash 0058cda)
|
charliewolfe
approved these changes
Mar 21, 2024
| } | ||
| #endif | ||
|
|
||
| } // API |
There was a problem hiding this comment.
I usually see closing namespace comments like } // namespace API.
| @@ -137,10 +133,6 @@ - (instancetype)init | |||
| _allowsPictureInPictureMediaPlayback = YES; | |||
| #endif | |||
|
|
|||
| _allowsInlineMediaPlayback = !PAL::currentUserInterfaceIdiomIsSmallScreen(); | |||
There was a problem hiding this comment.
#import <pal/system/ios/UserInterfaceIdiom.h> can probably be removed from this file now.
achristensen07
force-pushed
the
eng/Move-more-ivars-from-WKWebViewConfiguration-to-APIPageConfiguration
branch
from
0058cda
to
b279eb6
Compare
|
EWS run on previous version of this PR (hash b279eb6)
|
webkit-ews-buildbot
added
the
merging-blocked
achristensen07
removed
the
merging-blocked
achristensen07
force-pushed
the
eng/Move-more-ivars-from-WKWebViewConfiguration-to-APIPageConfiguration
branch
from
b279eb6
to
781cf7b
Compare
|
EWS run on current version of this PR (hash 781cf7b)
|
achristensen07
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=271405 rdar://125186260 Reviewed by Charlie Wolfe. * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::inlineMediaPlaybackRequiresPlaysInlineAttribute const): (API::PageConfiguration::setInlineMediaPlaybackRequiresPlaysInlineAttribute): (API::PageConfiguration::allowsInlineMediaPlaybackAfterFullscreen const): (API::PageConfiguration::setAllowsInlineMediaPlaybackAfterFullscreen): (API::PageConfiguration::mediaDataLoadsAutomatically const): (API::PageConfiguration::setMediaDataLoadsAutomatically): (API::PageConfiguration::dragLiftDelay const): (API::PageConfiguration::setDragLiftDelay): (API::PageConfiguration::textInteractionGesturesEnabled const): (API::PageConfiguration::setTextInteractionGesturesEnabled): (API::PageConfiguration::longPressActionsEnabled const): (API::PageConfiguration::setLongPressActionsEnabled): (API::PageConfiguration::systemPreviewEnabled const): (API::PageConfiguration::setSystemPreviewEnabled): (API::PageConfiguration::shouldDecidePolicyBeforeLoadingQuickLookPreview const): (API::PageConfiguration::setShouldDecidePolicyBeforeLoadingQuickLookPreview): * Source/WebKit/UIProcess/API/Cocoa/APIPageConfigurationCocoa.mm: Added. (API::PageConfiguration::Data::defaultShouldDecidePolicyBeforeLoadingQuickLookPreview): (API::PageConfiguration::Data::defaultDragLiftDelay): * Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (toDragLiftDelay): (toWKDragLiftDelay): (fromWKDragLiftDelay): (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _inlineMediaPlaybackRequiresPlaysInlineAttribute]): (-[WKWebViewConfiguration _setInlineMediaPlaybackRequiresPlaysInlineAttribute:]): (-[WKWebViewConfiguration _allowsInlineMediaPlaybackAfterFullscreen]): (-[WKWebViewConfiguration _setAllowsInlineMediaPlaybackAfterFullscreen:]): (-[WKWebViewConfiguration _dragLiftDelay]): (-[WKWebViewConfiguration _setDragLiftDelay:]): (-[WKWebViewConfiguration _longPressActionsEnabled]): (-[WKWebViewConfiguration _setLongPressActionsEnabled:]): (-[WKWebViewConfiguration _systemPreviewEnabled]): (-[WKWebViewConfiguration _setSystemPreviewEnabled:]): (-[WKWebViewConfiguration _shouldDecidePolicyBeforeLoadingQuickLookPreview]): (-[WKWebViewConfiguration _setShouldDecidePolicyBeforeLoadingQuickLookPreview:]): (-[WKWebViewConfiguration _mediaDataLoadsAutomatically]): (-[WKWebViewConfiguration _setMediaDataLoadsAutomatically:]): (-[WKWebViewConfiguration _textInteractionGesturesEnabled]): (-[WKWebViewConfiguration _setTextInteractionGesturesEnabled:]): (defaultShouldDecidePolicyBeforeLoadingQuickLookPreview): Deleted. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/276517@main
webkit-commit-queue
force-pushed
the
eng/Move-more-ivars-from-WKWebViewConfiguration-to-APIPageConfiguration
branch
from
781cf7b
to
b2db745
Compare
|
Committed 276517@main (b2db745): https://commits.webkit.org/276517@main Reviewed commits have been landed. Closing PR #26261 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b2db745
781cf7b
🧪 wpe-wk2🧪 api-mac🛠 tv-sim🛠 watch