Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the list of valid cursor types for Interaction Regions #26270

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

etiennesegonzac
Copy link
Contributor

@etiennesegonzac etiennesegonzac commented Mar 21, 2024

ba39cbd

Expand the list of valid cursor types for Interaction Regions
https://bugs.webkit.org/show_bug.cgi?id=271416
<rdar://118882598>

Reviewed by Tim Horton.

Add support for a few more cursor types instead of just `pointer`.
Starting with `move`, `grab`, `text` and `vertical-text`.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::hasInteractiveCursorType):
(WebCore::cursorTypeForElement): Deleted.
Rename the function and make it return a bool instead.
(WebCore::interactionRegionForRenderedRegion):
Use the new function.
(WebCore::shouldAllowNonInteractiveCursorForElement):
(WebCore::shouldAllowNonPointerCursorForElement): Deleted.
Rename the function to remove the "pointer" reference.

* LayoutTests/interaction-region/cursors-expected.txt: Added.
* LayoutTests/interaction-region/cursors.html: Added.
Add tests for for the cursors.

Canonical link: https://commits.webkit.org/276511@main

f60fd4e

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge 🛠 watch
✅ 🛠 watch-sim

@etiennesegonzac etiennesegonzac self-assigned this Mar 21, 2024
@etiennesegonzac etiennesegonzac added the Layout and Rendering For bugs with layout and rendering of Web pages. label Mar 21, 2024
@etiennesegonzac etiennesegonzac added the merge-queue Applied to send a pull request to merge-queue label Mar 22, 2024
https://bugs.webkit.org/show_bug.cgi?id=271416
<rdar://118882598>

Reviewed by Tim Horton.

Add support for a few more cursor types instead of just `pointer`.
Starting with `move`, `grab`, `text` and `vertical-text`.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::hasInteractiveCursorType):
(WebCore::cursorTypeForElement): Deleted.
Rename the function and make it return a bool instead.
(WebCore::interactionRegionForRenderedRegion):
Use the new function.
(WebCore::shouldAllowNonInteractiveCursorForElement):
(WebCore::shouldAllowNonPointerCursorForElement): Deleted.
Rename the function to remove the "pointer" reference.

* LayoutTests/interaction-region/cursors-expected.txt: Added.
* LayoutTests/interaction-region/cursors.html: Added.
Add tests for for the cursors.

Canonical link: https://commits.webkit.org/276511@main
@webkit-commit-queue
Copy link
Collaborator

Committed 276511@main (ba39cbd): https://commits.webkit.org/276511@main

Reviewed commits have been landed. Closing PR #26270 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ba39cbd into WebKit:main Mar 22, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
4 participants