Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webkitpy] Remove the SVN class #26563

Merged

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Mar 28, 2024

898d16e

[webkitpy] Remove the SVN class
https://bugs.webkit.org/show_bug.cgi?id=271838
rdar://125562437

Reviewed by Alexey Proskuryakov.

* Tools/Scripts/webkitpy/common/checkout/scm/__init__.py:
* Tools/Scripts/webkitpy/common/checkout/scm/detection.py:
(SCMDetector.detect_scm_system):
* Tools/Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
(SCMDetectorTest.test_detect_scm_system):
* Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(_git_diff):
(TimezoneOverride.__exit__):
(SVNTestRepository): Deleted.
(SVNTest): Deleted.
(GitSVNTest): Deleted.
* Tools/Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository.has_authorization_for_realm):
(SVN): Deleted.

Canonical link: https://commits.webkit.org/276789@main

460c6b4

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy 🧪 ios-wk2-wpt 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
🛠 tv-sim ✅ 🧪 api-gtk
🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@JonWBedard JonWBedard self-assigned this Mar 28, 2024
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Mar 28, 2024
@JonWBedard JonWBedard added the skip-ews Applied to prevent a change from being run on EWS label Mar 28, 2024
Copy link
Contributor

@aproskuryakov aproskuryakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs=me

@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 28, 2024
https://bugs.webkit.org/show_bug.cgi?id=271838
rdar://125562437

Reviewed by Alexey Proskuryakov.

* Tools/Scripts/webkitpy/common/checkout/scm/__init__.py:
* Tools/Scripts/webkitpy/common/checkout/scm/detection.py:
(SCMDetector.detect_scm_system):
* Tools/Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
(SCMDetectorTest.test_detect_scm_system):
* Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(_git_diff):
(TimezoneOverride.__exit__):
(SVNTestRepository): Deleted.
(SVNTest): Deleted.
(GitSVNTest): Deleted.
* Tools/Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository.has_authorization_for_realm):
(SVN): Deleted.

Canonical link: https://commits.webkit.org/276789@main
@webkit-commit-queue webkit-commit-queue merged commit 898d16e into WebKit:main Mar 28, 2024
@webkit-commit-queue
Copy link
Collaborator

Committed 276789@main (898d16e): https://commits.webkit.org/276789@main

Reviewed commits have been landed. Closing PR #26563 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 28, 2024
@JonWBedard JonWBedard deleted the eng/webkitpy-Remove-the-SVN-class branch April 3, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ews Applied to prevent a change from being run on EWS Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants