[WebGPU] RemoteBuffer::copy can result in an out of bounds write #29086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash f69b08c) |
mwyrzykowski
force-pushed
the
eng/WebGPU-RemoteBuffercopy-can-result-in-an-out-of-bounds-write
branch
from
f69b08c
to
8a69264
Compare
|
EWS run on previous version of this PR (hash 8a69264) |
tadeuzagallo
approved these changes
May 27, 2024
| @@ -89,7 +89,7 @@ auto BufferImpl::getBufferContents() -> MappedRange | |||
| return { nullptr, 0 }; | |||
|
|
|||
| auto* pointer = wgpuBufferGetBufferContents(m_backing.get()); | |||
| auto bufferSize = wgpuBufferGetSize(m_backing.get()); | |||
| auto bufferSize = wgpuBufferGetActualSize(m_backing.get()); | |||
There was a problem hiding this comment.
Would it be clearer if these were called wgpuBufferGetInitialSize and wgpuBufferGetCurrentSize?
mwyrzykowski
force-pushed
the
eng/WebGPU-RemoteBuffercopy-can-result-in-an-out-of-bounds-write
branch
from
8a69264
to
48d31a6
Compare
|
EWS run on current version of this PR (hash 48d31a6) |
webkit-commit-queue
force-pushed
the
eng/WebGPU-RemoteBuffercopy-can-result-in-an-out-of-bounds-write
branch
from
48d31a6
to
ef994b7
Compare
https://bugs.webkit.org/show_bug.cgi?id=274678 <radar://128591350> Reviewed by Tadeu Zagallo. RemoteBuffer::copy should use the actual buffer size, not the initial size. * Source/WebCore/Modules/WebGPU/Implementation/WebGPUBufferImpl.cpp: (WebCore::WebGPU::BufferImpl::getBufferContents): * Source/WebGPU/WebGPU/Buffer.mm: (wgpuBufferGetActualSize): * Source/WebGPU/WebGPU/WebGPU.h: * LayoutTests/fast/webgpu/regression/repro_274678-expected.txt: Added. * LayoutTests/fast/webgpu/regression/repro_274678.html: Added. Add regression test for running locally. Canonical link: https://commits.webkit.org/279368@main
webkit-commit-queue
force-pushed
the
eng/WebGPU-RemoteBuffercopy-can-result-in-an-out-of-bounds-write
branch
from
ef994b7
to
0fa174e
Compare
|
Committed 279368@main (0fa174e): https://commits.webkit.org/279368@main Reviewed commits have been landed. Closing PR #29086 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0fa174e
48d31a6
🧪 ios-wk2🧪 ios-wk2-wpt🧪 api-ios🧪 gtk-wk2🧪 api-gtk