Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGPU] A12x devices and earlier allowed for creation of more samplers than supported by the HW #29359

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented May 31, 2024

427a310

[WebGPU] A12x devices and earlier allowed for creation of more samplers than supported by the HW
https://bugs.webkit.org/show_bug.cgi?id=274334
<radar://128065020>

Reviewed by Dan Glastonbury.

Apple4 and Apple5 devices have Tier 1 AB support, not tier 2, but
their limits were set according to tier 1 limits.

Reland correcting Apple4 and Apple5 limits instead of removing them.

Apple3 is not supported by WebGPU core, rather only WebGPU compat mode, which we
don't have any validation for right now.

* LayoutTests/fast/webgpu/fuzz-274334-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-274334.html: Added.
* LayoutTests/TestExpectations
Add regression test.

* Source/WebGPU/WebGPU/HardwareCapabilities.mm:
(WebGPU::rawHardwareCapabilities):
(WebGPU::apple3): Deleted.

Canonical link: https://commits.webkit.org/279569@main

a1643c8

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this May 31, 2024
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label May 31, 2024
@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label May 31, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-A12x-devices-and-earlier-allowed-for-creation-of-more-samplers-than-supported-by-the-HW branch from a1643c8 to 0946c7f Compare May 31, 2024 08:59
…rs than supported by the HW

https://bugs.webkit.org/show_bug.cgi?id=274334
<radar://128065020>

Reviewed by Dan Glastonbury.

Apple4 and Apple5 devices have Tier 1 AB support, not tier 2, but
their limits were set according to tier 1 limits.

Reland correcting Apple4 and Apple5 limits instead of removing them.

Apple3 is not supported by WebGPU core, rather only WebGPU compat mode, which we
don't have any validation for right now.

* LayoutTests/fast/webgpu/fuzz-274334-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-274334.html: Added.
* LayoutTests/TestExpectations
Add regression test.

* Source/WebGPU/WebGPU/HardwareCapabilities.mm:
(WebGPU::rawHardwareCapabilities):
(WebGPU::apple3): Deleted.

Canonical link: https://commits.webkit.org/279569@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-A12x-devices-and-earlier-allowed-for-creation-of-more-samplers-than-supported-by-the-HW branch from 0946c7f to 427a310 Compare May 31, 2024 09:01
@webkit-commit-queue
Copy link
Collaborator

Committed 279569@main (427a310): https://commits.webkit.org/279569@main

Reviewed commits have been landed. Closing PR #29359 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 427a310 into WebKit:main May 31, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
3 participants