Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PGO] Fix build on intel machines #299

Merged
merged 0 commits into from Apr 18, 2022

Conversation

justinmichaud
Copy link
Contributor

@justinmichaud justinmichaud commented Apr 15, 2022

1f0330e

[PGO] Fix build on intel machines
https://bugs.webkit.org/show_bug.cgi?id=239396

Reviewed by Jonathan Bedard.

We should use the correct comparison operator for Perl strings when checking
if we are building with PGO profile generation enabled.

Canonical link: https://commits.webkit.org/249727@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@Constellation
Copy link
Member

@JonWBedard This change does not include ChangeLog.
Can we have a quick fix to auto-generate ChangeLog in git-webkit pr and/or check ChangeLog change existence before pushing a PR from git-webkit? We are getting this problem often, and review can miss it.

@JonWBedard
Copy link
Member

@JonWBedard This change does not include ChangeLog.
Can we have a quick fix to auto-generate ChangeLog in git-webkit pr and/or check ChangeLog change existence before pushing a PR from git-webkit? We are getting this problem often, and review can miss it.

Probably having Merge-Queue do this check is the easiest way to do this

@JonWBedard
Copy link
Member

@justinmichaud As another note, one of the reasons we recommend using git-webkit pr is because manual curated PRs aren't automatically linked back to their associated bugzilla

@cdumez
Copy link
Contributor

cdumez commented Apr 15, 2022

This patch seems to make the issue go away for me.

@webkit-early-warning-system
Copy link
Collaborator

Committed r292962 (249727@main): https://commits.webkit.org/249727@main

Reviewed commits have been landed. Closing PR #299 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Apr 18, 2022
@justinmichaud justinmichaud deleted the patch-1 branch April 18, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants