Mixing manual and named slot assignments causes slotchange event to be not dispatched #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
added
DOM
webkit-ews-buildbot
added
the
merging-blocked
anttijk
approved these changes
Aug 12, 2022
webkit-early-warning-system
force-pushed
the
fix243869
branch
from
4dc38b8
to
ecfb086
Compare
…e not dispatched https://bugs.webkit.org/show_bug.cgi?id=243869 Reviewed by Antti Koivisto. Fixed the bug that manually assigning a node to a slot inside a shadow tree in the named slot assignment mode does not enqueue slotchange as expected. * LayoutTests/fast/shadow-dom/imperative-named-slot-mixture-expected.txt: Added. * LayoutTests/fast/shadow-dom/imperative-named-slot-mixture.html: Added. * LayoutTests/platform/win/TestExpectations: * Source/WebCore/html/HTMLSlotElement.cpp: (WebCore::HTMLSlotElement::assign): Canonical link: https://commits.webkit.org/253392@main
webkit-early-warning-system
force-pushed
the
fix243869
branch
from
ecfb086
to
00898fe
Compare
|
Committed 253392@main (00898fe): https://commits.webkit.org/253392@main Reviewed commits have been landed. Closing PR #3258 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
00898fe