Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename initial value of color-scheme from auto to normal #3471

Merged
merged 0 commits into from Aug 22, 2022
Merged

Rename initial value of color-scheme from auto to normal #3471

merged 0 commits into from Aug 22, 2022

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Aug 19, 2022 •
edited by webkit-early-warning-system

1ec4bb7

Rename initial value of color-scheme from `auto` to `normal`
https://bugs.webkit.org/show_bug.cgi?id=205799
<rdar://58388530>

Reviewed by Darin Adler and Timothy Hatcher.

* LayoutTests/css-dark-mode/color-scheme-css-parse.html:
* LayoutTests/css-dark-mode/color-scheme-css-expected.txt:
* LayoutTests/css-dark-mode/color-scheme-css.html:
* LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt:
* LayoutTests/css-dark-mode/older-syntax/supported-color-schemes-css.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/inheritance-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-attribute-changes-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-empty-content-value-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-first-valid-applies-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-insert-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-no-content-value-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-remove-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-remove-head-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-single-value-in-body-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-single-value-in-head-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/meta/meta-color-scheme-single-value-in-shadow-tree-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/parsing/color-scheme-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/parsing/color-scheme-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-color-adjust/parsing/color-scheme-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-attribute-changes-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-empty-content-value-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-insert-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-no-content-value-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-head-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-body-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-head-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-shadow-tree-expected.txt:
* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeColorScheme):
* Source/WebCore/rendering/style/StyleColorScheme.h:
(WebCore::StyleColorScheme::isNormal const):
(WebCore::StyleColorScheme::isAuto const): Deleted.

Canonical link: https://commits.webkit.org/253659@main

b9abfba

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ❌ 🛠 ios   🛠 mac ❌ 🛠 wpe ❌ 🛠 🧪 win
❌ 🧪 bindings ❌ 🛠 ios-sim   🛠 mac-debug ❌ 🛠 gtk ❌ 🛠 wincairo
❌ 🧪 webkitperl ❌ 🧪 ios-wk2   🛠 mac-AS-debug ❌ 🧪 gtk-wk2
❌ 🧪 api-ios   🧪 api-mac ❌ 🧪 api-gtk
❌ 🛠 tv   🧪 mac-wk1
❌ 🛠 tv-sim   🧪 mac-wk2
❌ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ❌ 🛠 watch-sim   🧪 mac-wk2-stress

@nt1m nt1m self-assigned this Aug 19, 2022
@nt1m nt1m added CSS Cascading Style Sheets implementation Safari Technology Preview labels Aug 19, 2022
@nt1m nt1m changed the title Re Rename initial value of color-scheme from auto to normal Aug 19, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash ff2fb44)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ⏳ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 19, 2022
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Aug 19, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash f491cee)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ❌ 🛠 gtk ✅ 🛠 wincairo
❌ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ❌ 🧪 api-gtk
✅ 🛠 🧪 jsc ⏳ 🛠 tv ✅ 🧪 mac-wk1 ❌ 🛠 jsc-armv7
⏳ 🛠 tv-sim ❌ 🧪 mac-wk2 ❌ 🧪 jsc-armv7-tests
⏳ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2 ❌ 🛠 jsc-mips
⏳ 🛠 watch-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 jsc-mips-tests

@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 9094783)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ❌ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 20, 2022
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Aug 20, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 46a77ec)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ❌ 🛠 ios ⏳ 🛠 mac ❌ 🛠 wpe ❌ 🛠 🧪 win
❌ 🛠 ios-sim ⏳ 🛠 mac-debug ❌ 🛠 gtk ❌ 🛠 wincairo
❌ 🧪 webkitperl ❌ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
❌ 🧪 api-ios ⏳ 🧪 api-mac ❌ 🧪 api-gtk
❌ 🛠 tv ⏳ 🧪 mac-wk1
❌ 🛠 tv-sim ⏳ 🧪 mac-wk2
❌ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2
❌ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress

@nt1m nt1m force-pushed the color-scheme-normal branch 2 times, most recently from 46a77ec to a84dd8d Compare August 20, 2022 03:35
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash a84dd8d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-early-warning-system
Copy link
Collaborator

b9abfba

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ❌ 🛠 ios   🛠 mac ❌ 🛠 wpe ❌ 🛠 🧪 win
❌ 🧪 bindings ❌ 🛠 ios-sim   🛠 mac-debug ❌ 🛠 gtk ❌ 🛠 wincairo
❌ 🧪 webkitperl ❌ 🧪 ios-wk2   🛠 mac-AS-debug ❌ 🧪 gtk-wk2
❌ 🧪 api-ios   🧪 api-mac ❌ 🧪 api-gtk
❌ 🛠 tv   🧪 mac-wk1
❌ 🛠 tv-sim   🧪 mac-wk2
❌ 🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ❌ 🛠 watch-sim   🧪 mac-wk2-stress

@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 22, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 253659@main (1ec4bb7): https://commits.webkit.org/253659@main

Reviewed commits have been landed. Closing PR #3471 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 1ec4bb7 into WebKit:main Aug 22, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 22, 2022
@nt1m nt1m deleted the color-scheme-normal branch August 22, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxlcoder pxlcoder pxlcoder left review comments

@xeenon xeenon xeenon approved these changes

@darinadler darinadler darinadler approved these changes

Assignees

@nt1m nt1m

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
7 participants
@nt1m @webkit-early-warning-system @webkit-commit-queue @xeenon @pxlcoder @darinadler @webkit-ews-buildbot