Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce usage of std::unique_ptr<HashSet> / std::unique_ptr<HashMap> #439

Merged
merged 0 commits into from
Apr 29, 2022
Merged

Reduce usage of std::unique_ptr<HashSet> / std::unique_ptr<HashMap> #439

merged 0 commits into from
Apr 29, 2022

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 29, 2022

1d2fb8c

Reduce usage of std::unique_ptr<HashSet > / std::unique_ptr<HashMap >
https://bugs.webkit.org/show_bug.cgi?id=239903

Reviewed by Yusuke Suzuki.

Reduce usage of std::unique_ptr<HashSet > / std::unique_ptr<HashMap > as HashSet / HashMap
are already essentially pointers. This avoids some unnecessary dereferencing.

* Source/JavaScriptCore/heap/Heap.cpp:
(JSC::Heap::addCoreConstraints):
* Source/JavaScriptCore/heap/Heap.h:
* Source/JavaScriptCore/heap/HeapInlines.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebPasteboardOverrides.cpp:
(WebKit::WebPasteboardOverrides::addOverride):
(WebKit::WebPasteboardOverrides::removeOverride):
(WebKit::WebPasteboardOverrides::overriddenTypes):
(WebKit::WebPasteboardOverrides::getDataForOverride const):
* Source/WebKit/WebProcess/WebCoreSupport/WebPasteboardOverrides.h:
* Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::creatingDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::doneDeletingDatabase):
(WebCore::DatabaseTracker::isDeletingDatabase):
(WebCore::DatabaseTracker::canDeleteOrigin):
* Source/WebCore/Modules/webdatabase/DatabaseTracker.h:
* Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::wrapForDeprecatedCSSOM):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::didMutate):
* Source/WebCore/css/PropertySetCSSStyleDeclaration.h:
* Source/WebCore/dom/MutationObserver.cpp:
(WebCore::MutationObserver::deliver):
* Source/WebCore/dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::takeTransientRegistrations):
(WebCore::MutationObserverRegistration::isReachableFromOpaqueRoots const):
* Source/WebCore/dom/MutationObserverRegistration.h:
(WebCore::MutationObserverRegistration::hasTransientRegistrations const):
* Source/WebCore/platform/graphics/GlyphMetricsMap.h:
(WebCore::GlyphMetricsMap<T >::locatePageSlowCase):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::insertIntoTrackedRendererMaps):
(WebCore::removeFromTrackedRendererMaps):
(WebCore::removeBlockFromPercentageDescendantAndContainerMaps):
* Source/WebCore/style/StyleScope.cpp:
(WebCore::Style::Scope::updateActiveStyleSheets):
(WebCore::Style::Scope::activeStyleSheetsContains const):
* Source/WebCore/style/StyleScope.h:

Canonical link: https://commits.webkit.org/250141@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@cdumez cdumez self-assigned this Apr 29, 2022
@cdumez cdumez added WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). WebKit Nightly Build labels Apr 29, 2022
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Apr 29, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 1d2fb8c into WebKit:main Apr 29, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r293637 (250141@main): https://commits.webkit.org/250141@main

Reviewed commits have been landed. Closing PR #439 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Apr 29, 2022
@cdumez cdumez deleted the 239903_less_unique_ptr_HashSet branch April 29, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants