Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reporelaypy] Accept pull-request hooks #58

Merged
merged 0 commits into from
Dec 17, 2021
Merged

[reporelaypy] Accept pull-request hooks #58

merged 0 commits into from
Dec 17, 2021

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Dec 16, 2021 •
edited
Loading

61182db

[reporelaypy] Accept pull-request hooks
https://bugs.webkit.org/show_bug.cgi?id=234406
<rdar://problem/86598451 >

Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Bump version.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/hooks.py:
(HookProcessor):
(HookProcessor.is_valid): Check 'pull_request' hook format.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/hooks_unittest.py:
(HooksUnittest.test_pull_request):
* Tools/Scripts/libraries/reporelaypy/setup.py: Bump version.


Canonical link: https://commits.webkit.org/245355@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Dec 16, 2021
dewei-zhu
dewei-zhu approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@JonWBedard JonWBedard force-pushed the eng/accept-pull-request-hook branch 2 times, most recently from d42895c to 584048d Compare December 17, 2021 16:00
@JonWBedard JonWBedard merged commit 61182db into WebKit:main Dec 17, 2021
@JonWBedard
Copy link
Member Author

Landed https://commits.webkit.org/245355@main (61182db)!

@JonWBedard JonWBedard deleted the eng/accept-pull-request-hook branch December 17, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewei-zhu dewei-zhu dewei-zhu approved these changes

@sundiamonde sundiamonde Awaiting requested review from sundiamonde

Assignees

@JonWBedard JonWBedard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonWBedard @dewei-zhu