Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSE] Bring back some useful SourceBuffer logs #5854

Merged
merged 1 commit into from
Nov 2, 2022
Merged

[MSE] Bring back some useful SourceBuffer logs #5854

merged 1 commit into from
Nov 2, 2022

Commits on Nov 2, 2022

  1. [MSE] Bring back some useful SourceBuffer logs 

    https://bugs.webkit.org/show_bug.cgi?id=247122

Reviewed by Xabier Rodriguez-Calvar.

Changeset https://trac.webkit.org/changeset/241148/webkit from
https://bugs.webkit.org/show_bug.cgi?id=194348 removed line
WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710
, which was very useful when debugging MSE append problems.

This patch is bringing that line back and adding a similar one
to appendBufferInternal(), which will be helpful to track how
the buffered ranges evolve as the append is processed.

Original author: Pawel Lampe <pawel.lampe@gmail.com>
See: WebPlatformForEmbedded/WPEWebKit#955

* Source/WebCore/Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::appendBufferInternal): Added log line.
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto.

Canonical link: https://commits.webkit.org/256224@main
    @eocanha
    eocanha committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    e5e73c6 View commit details
    Browse the repository at this point in the history