Bring back some useful SourceBuffer logs#955
Closed
Scony wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.28from
Closed
Bring back some useful SourceBuffer logs#955Scony wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.28from
Scony wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.28from
Conversation
Member
|
@Scony, would these messages be still useful to you if they were declared as DEBUG_LOG()? I'd like to port this patch upstream and think that DEBUG_LOG() would pollute the logs a bit less for the general case. Do you agree? |
eocanha
added
wpe-2.28
Author
|
@eocanha yes, that makes sense - should I update this PR or will you create upstream patch from scratch anyway? |
Member
|
This PR is being tracked upstread in https://bugs.webkit.org/show_bug.cgi?id=247122 and WebKit/WebKit#5854. @Scony, I've already included the change to DEBUG_LOG() there, no need to update this PR. |
webkit-early-warning-system
pushed a commit
to eocanha/WebKit
that referenced
this pull request
Nov 2, 2022
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: WebPlatformForEmbedded/WPEWebKit#955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
eocanha
pushed a commit
that referenced
this pull request
Nov 2, 2022
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit/WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: #955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
Member
|
Upstream WebKit/WebKit#5854 landed as WebKit/WebKit@e5e73c6 and has been backported to wpe-2.28 as 1850751 and 6bc8894. Closing this PR. |
Author
|
thanks! |
Member
|
Also, upstream WebKit/WebKit#6044 landed as WebKit/WebKit@4456698 and has been backported to wpe-2.28 as c564c93 |
mnutt
pushed a commit
to movableink/webkit
that referenced
this pull request
Dec 6, 2022
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit/WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: WebPlatformForEmbedded#955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
calvaris
pushed a commit
that referenced
this pull request
Jan 31, 2023
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit/WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: #955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
calvaris
pushed a commit
that referenced
this pull request
Feb 1, 2023
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit/WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: #955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
calvaris
pushed a commit
that referenced
this pull request
Feb 10, 2023
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit/WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: #955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
calvaris
pushed a commit
that referenced
this pull request
Feb 17, 2023
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit/WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: #955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
calvaris
pushed a commit
that referenced
this pull request
Feb 23, 2023
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit/WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: #955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
calvaris
pushed a commit
that referenced
this pull request
Feb 24, 2023
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit/WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: #955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
calvaris
pushed a commit
that referenced
this pull request
Mar 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit/WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: #955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
calvaris
pushed a commit
that referenced
this pull request
Mar 9, 2023
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit/WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: #955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
calvaris
pushed a commit
that referenced
this pull request
Mar 15, 2023
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit/WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: #955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
rawoul
pushed a commit
to rawoul/WebKit
that referenced
this pull request
Jun 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=247122 Reviewed by Xabier Rodriguez-Calvar. Changeset https://trac.webkit.org/changeset/241148/webkit from https://bugs.webkit.org/show_bug.cgi?id=194348 removed line WebKit@cd4e7eb#diff-78280e252e732edbf1f9b6517bd2f98eb1475f16fc781a5f3e2e2e6bf9b2a9beL710 , which was very useful when debugging MSE append problems. This patch is bringing that line back and adding a similar one to appendBufferInternal(), which will be helpful to track how the buffered ranges evolve as the append is processed. Original author: Pawel Lampe <pawel.lampe@gmail.com> See: WebPlatformForEmbedded/WPEWebKit#955 * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::appendBufferInternal): Added log line. (WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Ditto. Canonical link: https://commits.webkit.org/256224@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.