Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InjectedBundlePagePolicyClient #5889

Commits on Nov 9, 2022

  1. Remove InjectedBundlePagePolicyClient

    https://bugs.webkit.org/show_bug.cgi?id=247169
    rdar://101655797
    
    Reviewed by Tim Horton.
    
    There was one layout test, fast/loader/policy-delegate-action-hit-test-zoomed.html,
    which printed the dom node path of the clicked link.  This functionality is not available
    nor needed in WK2.  The WK1 test still verifies it.  WK2 has _WKHitTestResult with tests
    to verify we get the node info we need in this case.
    
    * Source/WebKit/Sources.txt:
    * Source/WebKit/WebKit.xcodeproj/project.pbxproj:
    * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
    (WKBundlePageSetPolicyClient):
    * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: Removed.
    * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Removed.
    * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
    (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
    (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
    (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
    (WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy):
    * Source/WebKit/WebProcess/WebPage/WebPage.cpp:
    (WebKit::WebPage::close):
    (WebKit::WebPage::initializeInjectedBundlePolicyClient): Deleted.
    * Source/WebKit/WebProcess/WebPage/WebPage.h:
    (WebKit::WebPage::injectedBundleLoaderClient):
    (WebKit::WebPage::injectedBundlePolicyClient): Deleted.
    
    Canonical link: https://commits.webkit.org/256491@main
    Alex Christensen authored and achristensen07 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    9eeab8d View commit details
    Browse the repository at this point in the history