-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove InjectedBundlePagePolicyClient #5889
Remove InjectedBundlePagePolicyClient #5889
Conversation
EWS run on previous version of this PR (hash 1e51d06) |
1e51d06
to
6b95a38
Compare
EWS run on previous version of this PR (hash 6b95a38) |
6b95a38
to
ed78d67
Compare
EWS run on previous version of this PR (hash ed78d67) |
ed78d67
to
9da8a08
Compare
EWS run on previous version of this PR (hash 9da8a08) |
9da8a08
to
be10e5c
Compare
EWS run on previous version of this PR (hash be10e5c) |
be10e5c
to
420fcf8
Compare
EWS run on previous version of this PR (hash 420fcf8) |
420fcf8
to
2efcd95
Compare
EWS run on previous version of this PR (hash 2efcd95) |
2efcd95
to
6798dca
Compare
EWS run on previous version of this PR (hash 6798dca) |
6798dca
to
bcb2242
Compare
EWS run on current version of this PR (hash bcb2242) |
@@ -6,6 +6,7 @@ | |||
if (window.testRunner) { | |||
testRunner.dumpAsText(); | |||
testRunner.setCustomPolicyDelegate(true); | |||
if (testRunner.skipPolicyDelegateNotifyDone) { testRunner.skipPolicyDelegateNotifyDone() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the weird style? Should be on the next line with no curly braces, just like in C++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS is slightly different than C++ in its handling of if statements with/without {} and I like to do this to be as unambiguous as possible.
https://bugs.webkit.org/show_bug.cgi?id=247169 rdar://101655797 Reviewed by Tim Horton. There was one layout test, fast/loader/policy-delegate-action-hit-test-zoomed.html, which printed the dom node path of the clicked link. This functionality is not available nor needed in WK2. The WK1 test still verifies it. WK2 has _WKHitTestResult with tests to verify we get the node info we need in this case. * Source/WebKit/Sources.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetPolicyClient): * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: Removed. * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Removed. * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): (WebKit::WebPage::initializeInjectedBundlePolicyClient): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: (WebKit::WebPage::injectedBundleLoaderClient): (WebKit::WebPage::injectedBundlePolicyClient): Deleted. Canonical link: https://commits.webkit.org/256491@main
bcb2242
to
9eeab8d
Compare
Committed 256491@main (9eeab8d): https://commits.webkit.org/256491@main Reviewed commits have been landed. Closing PR #5889 and removing active labels. |
9eeab8d
bcb2242