New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedicated worker and shared worker global scope should use the response URL #6250
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
youennf:eng/Dedicated-worker-and-shared-worker-global-scope-should-use-the-response-URL
Nov 10, 2022
Merged
Dedicated worker and shared worker global scope should use the response URL #6250
webkit-commit-queue
merged 1 commit into
WebKit:main
from
youennf:eng/Dedicated-worker-and-shared-worker-global-scope-should-use-the-response-URL
Nov 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youennf
added
Service Workers
Component for Service Workers bugs.
WebKit Nightly Build
labels
Nov 8, 2022
EWS run on previous version of this PR (hash a087af0) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Nov 8, 2022
youennf
force-pushed
the
eng/Dedicated-worker-and-shared-worker-global-scope-should-use-the-response-URL
branch
from
November 9, 2022 08:03
a087af0
to
3159e12
Compare
EWS run on previous version of this PR (hash 3159e12) |
youennf
force-pushed
the
eng/Dedicated-worker-and-shared-worker-global-scope-should-use-the-response-URL
branch
from
November 9, 2022 13:49
3159e12
to
fb83411
Compare
EWS run on previous version of this PR (hash fb83411) |
GTK test needs rebasing. |
cdumez
approved these changes
Nov 9, 2022
youennf
force-pushed
the
eng/Dedicated-worker-and-shared-worker-global-scope-should-use-the-response-URL
branch
from
November 10, 2022 10:49
fb83411
to
7f656c5
Compare
EWS run on current version of this PR (hash 7f656c5) |
youennf
added
merge-queue
Applied to send a pull request to merge-queue
and removed
merging-blocked
Applied to prevent a change from being merged
labels
Nov 10, 2022
β¦se URL https://bugs.webkit.org/show_bug.cgi?id=247615 rdar://problem/102088086 Reviewed by Chris Dumez. As per https://html.spec.whatwg.org/multipage/workers.html#run-a-worker step 14.3.1, we should use the response URL. Update the code accordingly, which allows removing the redirectReceived callback. Update DocumentThreadableLoader to provide a correct response URL, including fragment identifier. As DocumentThreadableLoader may reuse existing loads with same URL but different fragment identifier, we need to correctly set the response URL fragment identifier ourselves. Covered by rebased test. * LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception-redirect.https-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception-redirect.https-expected.txt: * Source/WebCore/loader/DocumentThreadableLoader.cpp: * Source/WebCore/loader/DocumentThreadableLoader.h: * Source/WebCore/loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::redirectReceived): Deleted. * Source/WebCore/loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::redirectReceived): Deleted. * Source/WebCore/loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::MainThreadBridge::redirectReceived): Deleted. * Source/WebCore/loader/WorkerThreadableLoader.h: * Source/WebCore/workers/Worker.cpp: (WebCore::Worker::notifyFinished): * Source/WebCore/workers/WorkerFetchResult.h: (WebCore::WorkerFetchResult::isolatedCopy const): (WebCore::WorkerFetchResult::encode const): (WebCore::WorkerFetchResult::decode): * Source/WebCore/workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::WorkerScriptLoader::fetchResult const): (WebCore::WorkerScriptLoader::redirectReceived): Deleted. * Source/WebCore/workers/WorkerScriptLoader.h: (WebCore::WorkerScriptLoader::url const): (WebCore::WorkerScriptLoader::lastRequestURL const): Deleted. * Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp: (WebCore::generateWorkerParameters): * Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp: (WebKit::WebSharedWorkerContextManagerConnection::launchSharedWorker): Canonical link: https://commits.webkit.org/256532@main
webkit-commit-queue
force-pushed
the
eng/Dedicated-worker-and-shared-worker-global-scope-should-use-the-response-URL
branch
from
November 10, 2022 14:30
7f656c5
to
99d5398
Compare
Committed 256532@main (99d5398): https://commits.webkit.org/256532@main Reviewed commits have been landed. Closing PR #6250 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
99d5398
7f656c5
π§ͺ ios-wk2π§ͺ api-iosπ§ͺ mac-wk1π§ͺ mac-AS-debug-wk2