Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard smooth scrolling animation is not disabled when NSScrollAnimationEnabled is false #6409

Merged
merged 1 commit into from
Nov 14, 2022

Commits on Nov 14, 2022

  1. Keyboard smooth scrolling animation is not disabled when `NSScrollAni…

    …mationEnabled` is `false`
    
    https://bugs.webkit.org/show_bug.cgi?id=247822
    rdar://101225956
    
    Reviewed by Simon Fraser.
    
    Previously, setting `NSScrollAnimationEnabled` to `false` would disable all
    scroll animations. However, enabling keyboard smooth scrolling regressed this
    and did not respect this setting any longer.
    
    This PR fixes this by having `EventHandlerDrivenSmoothScrolling` respect the
    value of `NSScrollAnimationEnabled` so now scroll animations may once again be
    disabled.
    
    * Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:
    
    Canonical link: https://commits.webkit.org/256661@main
    rr-codes committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    207c359 View commit details
    Browse the repository at this point in the history