Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard smooth scrolling animation is not disabled when NSScrollAnimationEnabled is false #6409

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Keyboard smooth scrolling animation is not disabled when NSScrollAnimationEnabled is false #6409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
View file
Open in desktop
Expand Up @@ -289,7 +289,7 @@ EventHandlerDrivenSmoothKeyboardScrollingEnabled:
WebKitLegacy:
default: false
WebKit:
"PLATFORM(COCOA)": true
"PLATFORM(MAC)": WebKit::defaultScrollAnimatorEnabled()
default: false
WebCore:
default: false
Expand Down
7 changes: 7 additions & 0 deletions Tools/WebKitTestRunner/TestOptions.cpp
View file
Open in desktop
Expand Up @@ -51,6 +51,12 @@ static constexpr bool fullGPUProcessEnabledValue = true;
static constexpr bool fullGPUProcessEnabledValue = false;
#endif

#if PLATFORM(MAC)
static constexpr bool eventHandlerDrivenSmoothKeyboardScrollingEnabledValue = true;
#else
static constexpr bool eventHandlerDrivenSmoothKeyboardScrollingEnabledValue = false;
#endif

const TestFeatures& TestOptions::defaults()
{
static TestFeatures features;
Expand Down Expand Up @@ -82,6 +88,7 @@ const TestFeatures& TestOptions::defaults()
{ "DataTransferItemsEnabled", true },
{ "DeveloperExtrasEnabled", true },
{ "DirectoryUploadEnabled", true },
{ "EventHandlerDrivenSmoothKeyboardScrollingEnabled", eventHandlerDrivenSmoothKeyboardScrollingEnabledValue },
{ "ExposeSpeakersEnabled", true },
{ "FrameFlatteningEnabled", false },
{ "FullScreenEnabled", true },
Expand Down