CSS Keywords should be lowercased during serialization

[cdumez]

5c14835

CSS Keywords should be lowercased during serialization
https://bugs.webkit.org/show_bug.cgi?id=249438

Reviewed by Sam Weinig.

CSS Keywords should be lowercased during serialization:
- https://www.w3.org/TR/cssom-1/#serialize-a-css-component-value

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/color-interpolation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/pointer-events-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-rendering-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-rendering-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/inheritance-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/parsing/color-interpolation-filters-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/parsing/color-interpolation-filters-parsing-valid-expected.txt:
Rebaseline WPT tests now that more checks are passing.

* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const):
Call nameStringForSerialization() instead of nameString() since we are serializing.
This makes sure that the identifier is serialized as lowercase.

* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::reifyValue):
Per https://drafts.css-houdini.org/css-typed-om-1/#reify-ident, we should create
a CSSKeywordValue from the *serialization* of the identifier, which means that
the identifier would become lowercase.

* Source/WebCore/css/process-css-values.py:
(GenerationContext):
Generate nameStringForSerialization() which provides the name string of the
keyword as lowercase, for the purpose of serialization.

Canonical link: https://commits.webkit.org/258024@main

0cc1187

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	🧪 api-mac	✅ 🧪 gtk-wk2
	⏳ 🧪 api-ios	✅ 🧪 mac-wk1	🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 2969848)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk2
	✅ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 14a9a50)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	✅ 🧪 gtk-wk2
	🧪 api-ios	✅ 🧪 mac-wk1	🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 0cc1187)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	🧪 api-mac	✅ 🧪 gtk-wk2
	⏳ 🧪 api-ios	✅ 🧪 mac-wk1	🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 83a1e20)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
⏳ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
⏳ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	🧪 ios-wk2	⏳ 🧪 api-mac	🧪 gtk-wk2
⏳ 🧪 webkitpy	🧪 api-ios	⏳ 🧪 mac-wk1	🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	⏳ 🧪 mac-wk2
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv-sim	⏳ 🧪 mac-AS-debug-wk2
⏳ 🧪 services	⏳ 🛠 watch	🧪 mac-wk2-stress
	⏳ 🛠 watch-sim

[darinadler]

Haven‘t looked over the change yet but occurs to me that during serialization we just need literals not actual strings since we are concatenations. So I would suggest a nameLiteralForSerialization function instead.

[cdumez]

Haven‘t looked over the change yet but occurs to me that during serialization we just need literals not actual strings since we are concatenations. So I would suggest a nameLiteralForSerialization function instead.

My patch introduces nameLiteralForSerialization() too. However, I am calling nameForSerialization in the CSS logic because of the prototype (and pre-existing code):

String CSSPrimitiveValue::formatNumberForCustomCSSText()
{
   // ...
    case CSSUnitType::CSS_VALUE_ID:
         // Per the specification, we should lowercase keywords during serialization:
         // https://www.w3.org/TR/cssom-1/#serialize-a-css-component-value
         return nameStringForSerialization(m_value.valueID);
}

[webkit-commit-queue]

Committed 258024@main (5c14835): https://commits.webkit.org/258024@main

Reviewed commits have been landed. Closing PR #7726 and removing active labels.