Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPI WKNavigationAction._targetFrameName #7787

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Add SPI WKNavigationAction._targetFrameName #7787

merged 1 commit into from
Jul 23, 2023

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Dec 16, 2022 •
edited by webkit-early-warning-system

e31512b

Add SPI WKNavigationAction._targetFrameName
https://bugs.webkit.org/show_bug.cgi?id=249505
rdar://103446360

Reviewed by Brady Eidson.

This will help the last 2 clients migrate from
WKPageSetPagePolicyClient to WKNavigationDelegate and WKUIDelegate.

* Source/WebKit/UIProcess/API/APINavigationAction.h:
* Source/WebKit/UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction _targetFrameName]):
* Source/WebKit/UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::createNewPage):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm:
(TEST):

Canonical link: https://commits.webkit.org/266233@main

d78b2a6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@achristensen07 achristensen07 self-assigned this Dec 16, 2022
@achristensen07 achristensen07 added the WebKit API For issues and bugs in the Web Kit public embedding APIs label Dec 16, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 16, 2022 •
edited

EWS run on previous version of this PR (hash a74e193)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🛠 gtk
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 17, 2022
@achristensen07 achristensen07 force-pushed the eng/Add-SPI-WKNavigationAction-_targetFrameName branch from a74e193 to 6b3ad60 Compare July 22, 2023 22:30
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 22, 2023 •
edited

EWS run on previous version of this PR (hash 6b3ad60)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@achristensen07 achristensen07 force-pushed the eng/Add-SPI-WKNavigationAction-_targetFrameName branch from 6b3ad60 to 9a9ae0c Compare July 22, 2023 22:33
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 22, 2023 •
edited

EWS run on previous version of this PR (hash 9a9ae0c)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@achristensen07 achristensen07 force-pushed the eng/Add-SPI-WKNavigationAction-_targetFrameName branch from 9a9ae0c to f1fd7db Compare July 22, 2023 22:38
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 22, 2023 •
edited

EWS run on previous version of this PR (hash f1fd7db)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ❌ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@achristensen07 achristensen07 force-pushed the eng/Add-SPI-WKNavigationAction-_targetFrameName branch from f1fd7db to 7c1a3af Compare July 22, 2023 22:53
@achristensen07 achristensen07 requested a review from a team as a code owner July 22, 2023 22:53
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 22, 2023 •
edited

EWS run on previous version of this PR (hash 7c1a3af)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@achristensen07 achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Jul 22, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 22, 2023
@achristensen07 achristensen07 force-pushed the eng/Add-SPI-WKNavigationAction-_targetFrameName branch from 7c1a3af to d78b2a6 Compare July 22, 2023 22:57
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 22, 2023 •
edited

EWS run on current version of this PR (hash d78b2a6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@achristensen07 achristensen07 added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jul 22, 2023
@achristensen07
Add SPI WKNavigationAction._targetFrameName
e31512b 
https://bugs.webkit.org/show_bug.cgi?id=249505
rdar://103446360

Reviewed by Brady Eidson.

This will help the last 2 clients migrate from
WKPageSetPagePolicyClient to WKNavigationDelegate and WKUIDelegate.

* Source/WebKit/UIProcess/API/APINavigationAction.h:
* Source/WebKit/UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction _targetFrameName]):
* Source/WebKit/UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::createNewPage):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm:
(TEST):

Canonical link: https://commits.webkit.org/266233@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-SPI-WKNavigationAction-_targetFrameName branch from d78b2a6 to e31512b Compare July 23, 2023 00:53
@webkit-commit-queue
Copy link
Collaborator

Committed 266233@main (e31512b): https://commits.webkit.org/266233@main

Reviewed commits have been landed. Closing PR #7787 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 23, 2023
@webkit-commit-queue webkit-commit-queue merged commit e31512b into WebKit:main Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beidson beidson beidson approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@achristensen07 achristensen07

Labels
WebKit API For issues and bugs in the Web Kit public embedding APIs
Projects
None yet
Milestone
No milestone
5 participants
@achristensen07 @webkit-early-warning-system @webkit-commit-queue @beidson @webkit-ews-buildbot