Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION (256812@main): [macOS] ASSERTION FAILED: m_element in WebKit::WebFullScreenManager::setAnimatingFullScreen() #8008

Conversation

ryanhaddad
Copy link
Contributor

@ryanhaddad ryanhaddad commented Dec 22, 2022

b395978

REGRESSION (256812@main): [macOS] ASSERTION FAILED: m_element in WebKit::WebFullScreenManager::setAnimatingFullScreen()
https://bugs.webkit.org/show_bug.cgi?id=248093
rdar://102522154

Unreviewed test gardening.

Disable the tests in the debug configuration.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenVideoTextRecognition.mm:
* Tools/TestWebKitAPI/Tests/mac/FullscreenFocus.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/258258@main

566df15

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ πŸ§ͺ style   πŸ›  ios   πŸ›  mac   πŸ›  wpe   πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim   πŸ›  mac-AS-debug   πŸ›  gtk   πŸ›  wincairo
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios   πŸ§ͺ mac-wk1   πŸ§ͺ api-gtk
  πŸ›  tv   πŸ§ͺ mac-wk2
  πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2
  πŸ›  watch   πŸ§ͺ mac-wk2-stress
  πŸ›  watch-sim
βœ… πŸ›  πŸ§ͺ unsafe-merge

@ryanhaddad ryanhaddad self-assigned this Dec 22, 2022
@ryanhaddad ryanhaddad added the Media Bugs related to the HTML 5 Media elements. label Dec 22, 2022
@ryanhaddad ryanhaddad added skip-ews Applied to prevent a change from being run on EWS and removed skip-ews Applied to prevent a change from being run on EWS labels Dec 22, 2022
@ryanhaddad ryanhaddad force-pushed the eng/REGRESSION-256812main-macOS-ASSERTION-FAILED-m_element-in-WebKitWebFullScreenManagersetAnimatingFullScreen branch from 6c2309b to ce8a96c Compare December 22, 2022 18:21
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 22, 2022
@ryanhaddad ryanhaddad removed the merging-blocked Applied to prevent a change from being merged label Dec 22, 2022
@ryanhaddad ryanhaddad force-pushed the eng/REGRESSION-256812main-macOS-ASSERTION-FAILED-m_element-in-WebKitWebFullScreenManagersetAnimatingFullScreen branch from ce8a96c to 566df15 Compare December 22, 2022 21:41
@ryanhaddad ryanhaddad added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 22, 2022
…it::WebFullScreenManager::setAnimatingFullScreen()

https://bugs.webkit.org/show_bug.cgi?id=248093
rdar://102522154

Unreviewed test gardening.

Disable the tests in the debug configuration.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenVideoTextRecognition.mm:
* Tools/TestWebKitAPI/Tests/mac/FullscreenFocus.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/258258@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/REGRESSION-256812main-macOS-ASSERTION-FAILED-m_element-in-WebKitWebFullScreenManagersetAnimatingFullScreen branch from 566df15 to b395978 Compare December 22, 2022 21:45
@webkit-commit-queue
Copy link
Collaborator

Test gardening commit 258258@main (b395978): https://commits.webkit.org/258258@main

Reviewed commits have been landed. Closing PR #8008 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit b395978 into WebKit:main Dec 22, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
4 participants