text-decoration-thickness property doesn't always trigger repaint when changed #8372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt1m
added
the
Text
nt1m
requested review from
litherum,
darinadler,
smfr,
anttijk and
alanbaradlay
and removed request for
litherum
nt1m
force-pushed
the
eng/text-decoration-thickness-property-doesnt-always-trigger-repaint-when-changed
branch
from
809ff02
to
2b0b6a3
Compare
|
EWS run on previous version of this PR (hash 2b0b6a3)
|
|
EWS run on previous version of this PR (hash 809ff02) |
nt1m
added
the
request-merge-queue
webkit-ews-buildbot
added
merging-blocked
darinadler
approved these changes
Jan 8, 2023
nt1m
force-pushed
the
eng/text-decoration-thickness-property-doesnt-always-trigger-repaint-when-changed
branch
from
2b0b6a3
to
42d8bce
Compare
nt1m
added
the
unsafe-merge-queue
|
EWS run on current version of this PR (hash 42d8bce)
|
…n changed https://bugs.webkit.org/show_bug.cgi?id=224483 rdar://76895249 Reviewed by Darin Adler. RenderStyle::changeRequiresRepaintIfText() should return true when text-decoration-thickness changes. GOV.UK bug tracker: alphagov/reported-bugs#60 * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/invalidation/text-decoration-thickness-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/invalidation/text-decoration-thickness-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/invalidation/text-decoration-thickness.html: Added. * LayoutTests/platform/ios/TestExpectations: * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::changeRequiresRepaintIfText const): Canonical link: https://commits.webkit.org/258641@main
webkit-early-warning-system
force-pushed
the
eng/text-decoration-thickness-property-doesnt-always-trigger-repaint-when-changed
branch
from
42d8bce
to
6be98ae
Compare
|
Committed 258641@main (6be98ae): https://commits.webkit.org/258641@main Reviewed commits have been landed. Closing PR #8372 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
nt1m
deleted the
eng/text-decoration-thickness-property-doesnt-always-trigger-repaint-when-changed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6be98ae
42d8bce
🧪 bindings🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 tv🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2🧪 mac-wk2-stress🛠 watch-sim