Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text-decoration-thickness property doesn't always trigger repaint when changed #8372

Merged
merged 1 commit into from
Jan 8, 2023
Merged

text-decoration-thickness property doesn't always trigger repaint when changed #8372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...eb-platform-tests/css/css-text-decor/invalidation/text-decoration-thickness-expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<!DOCTYPE html>
<html>
<meta charset="utf-8">
<title>text-decoration-thickness invalidation reference</title>
<style>
:link {
text-decoration: underline;
text-decoration-thickness: 3px;
}
</style>
<div style="font-size: 28px;">
<a href="#" id="link">Hover over this link, and check if the text-decoration-thickness increases.</a>
</div>
</html>
14 changes: 14 additions & 0 deletions ...w3c/web-platform-tests/css/css-text-decor/invalidation/text-decoration-thickness-ref.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<!DOCTYPE html>
<html>
<meta charset="utf-8">
<title>text-decoration-thickness invalidation reference</title>
<style>
:link {
text-decoration: underline;
text-decoration-thickness: 3px;
}
</style>
<div style="font-size: 28px;">
<a href="#" id="link">Hover over this link, and check if the text-decoration-thickness increases.</a>
</div>
</html>
32 changes: 32 additions & 0 deletions ...ted/w3c/web-platform-tests/css/css-text-decor/invalidation/text-decoration-thickness.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<!DOCTYPE html>
<html class="reftest-wait">
<meta charset="utf-8">
<title>text-decoration-thickness invalidation</title>
<link rel="author" title="Tim Nguyen" href="https://github.com/nt1m">
<link rel="help" href="https://drafts.csswg.org/selectors/#the-hover-pseudo">
<link rel="help" href="https://drafts.csswg.org/css-text-decor-4/#text-decoration-thickness-property">
<link rel="match" href="text-decoration-thickness-ref.html">
<style>
:link {
text-decoration: underline;
text-decoration-thickness: 1px;
}
:link:hover {
text-decoration-thickness: 3px;
}
</style>
<div style="font-size: 28px;">
<a href="#" id="link">Hover over this link, and check if the text-decoration-thickness increases.</a>
</div>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-actions.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script>
window.addEventListener("load", async () => {
// Hover the link
await new test_driver.Actions().pointerMove(0, 0, { origin: link }).send();

document.documentElement.classList.remove("reftest-wait");
});
</script>
</html>
5 changes: 4 additions & 1 deletion LayoutTests/platform/ios/TestExpectations
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3193,7 +3193,10 @@ webkit.org/b/209734 imported/w3c/web-platform-tests/css/selectors/focus-visible-
webkit.org/b/209734 imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-017.tentative.html [ Skip ]
webkit.org/b/209734 imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-018.html [ Skip ]
webkit.org/b/209734 imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-019.html [ Skip ]
webkit.org/b/209734 imported/w3c/web-platform-tests/css/selectors/hover-002.html [ Skip ]

# :hover simulation not working on iOS
imported/w3c/web-platform-tests/css/selectors/hover-002.html [ Skip ]
imported/w3c/web-platform-tests/css/css-text-decor/invalidation/text-decoration-thickness.html [ Skip ]

# Certain versions of iOS use different text security characters.
webkit.org/b/209692 platform/ios/fast/text/text-security-disc-bullet-pua-ios-new.html [ Pass ]
Expand Down
1 change: 1 addition & 0 deletions Source/WebCore/rendering/style/RenderStyle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,6 +1242,7 @@ bool RenderStyle::changeRequiresRepaintIfText(const RenderStyle& other, OptionSe
|| m_visualData->textDecorationLine != other.m_visualData->textDecorationLine
|| m_rareNonInheritedData->textDecorationStyle != other.m_rareNonInheritedData->textDecorationStyle
|| m_rareNonInheritedData->textDecorationColor != other.m_rareNonInheritedData->textDecorationColor
|| m_rareNonInheritedData->textDecorationThickness != other.m_rareNonInheritedData->textDecorationThickness
|| m_rareInheritedData->textDecorationSkipInk != other.m_rareInheritedData->textDecorationSkipInk
|| m_rareInheritedData->textFillColor != other.m_rareInheritedData->textFillColor
|| m_rareInheritedData->textStrokeColor != other.m_rareInheritedData->textStrokeColor
Expand Down