-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Effectively revert 258484@main #8652
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
achristensen07:eng/Effectively-revert-258484main
Jan 14, 2023
Merged
Effectively revert 258484@main #8652
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
achristensen07:eng/Effectively-revert-258484main
Jan 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on current version of this PR (hash 81ef599) |
achristensen07
added
the
WebKit Process Model
Bugs related to WebKit's multi-process architecture
label
Jan 14, 2023
achristensen07
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Jan 14, 2023
https://bugs.webkit.org/show_bug.cgi?id=250614 rdar://104223231 Unreviewed. It likely caused an issue with watchOS. Revert it and the associated fixes while keeping everything building and running nicely. * Source/WTF/wtf/Int128.h: (WTF::DefaultHash<UInt128>::hash): Deleted. (WTF::DefaultHash<UInt128>::equal): Deleted. (WTF::DefaultHash<Int128>::hash): Deleted. (WTF::DefaultHash<Int128>::equal): Deleted. (WTF::HashTraits<UInt128>::constructDeletedValue): Deleted. (WTF::HashTraits<UInt128>::isDeletedValue): Deleted. (WTF::HashTraits<Int128>::constructDeletedValue): Deleted. (WTF::HashTraits<Int128>::isDeletedValue): Deleted. (IPC::ArgumentCoder<WTF::UInt128>::encode): Deleted. (IPC::ArgumentCoder<WTF::UInt128>::decode): Deleted. (IPC::ArgumentCoder<WTF::Int128>::encode): Deleted. (IPC::ArgumentCoder<WTF::Int128>::decode): Deleted. * Source/WTF/wtf/ObjectIdentifier.h: (WTF::makeObjectIdentifier): * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::didReceiveMessage): (WebKit::NetworkProcess::didReceiveSyncMessage): (WebKit::NetworkProcess::findPendingDownloadLocation): * Source/WebKit/Platform/IPC/Connection.cpp: (IPC::Connection::WaitForMessageState::WaitForMessageState): (IPC::Connection::SyncMessageState::dispatchMessages): (IPC::Connection::addWorkQueueMessageReceiver): (IPC::Connection::removeWorkQueueMessageReceiver): (IPC::Connection::addMessageReceiver): (IPC::Connection::removeMessageReceiver): (IPC::Connection::createSyncMessageEncoder): (IPC::Connection::waitForMessage): * Source/WebKit/Platform/IPC/Connection.h: (IPC::Connection::sendWithAsyncReply): (IPC::Connection::send): (IPC::Connection::sendSync): (IPC::Connection::waitForAndDispatchImmediately): (IPC::Connection::waitForAsyncReplyAndDispatchImmediately): (IPC::Connection::waitForMessageForTesting): * Source/WebKit/Platform/IPC/Decoder.cpp: (IPC::Decoder::Decoder): * Source/WebKit/Platform/IPC/Decoder.h: (IPC::Decoder::destinationID const): * Source/WebKit/Platform/IPC/Encoder.cpp: (IPC::Encoder::Encoder): * Source/WebKit/Platform/IPC/Encoder.h: * Source/WebKit/Platform/IPC/MessageReceiveQueueMap.h: * Source/WebKit/Platform/IPC/MessageReceiverMap.cpp: (IPC::MessageReceiverMap::addMessageReceiver): (IPC::MessageReceiverMap::removeMessageReceiver): * Source/WebKit/Platform/IPC/MessageReceiverMap.h: * Source/WebKit/Platform/IPC/MessageSender.h: (IPC::MessageSender::send): (IPC::MessageSender::sendSync): (IPC::MessageSender::sendWithAsyncReply): * Source/WebKit/Platform/IPC/ReceiverMatcher.h: (IPC::ReceiverMatcher::ReceiverMatcher): (IPC::ReceiverMatcher::createWithZeroAsAnyDestination): (IPC::ReceiverMatcher::matches const): * Source/WebKit/Scripts/webkit/messages.py: (generate_message_handler): * Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessageReceiver.cpp: (WebKit::TestWithCVPixelBuffer::didReceiveMessage): * Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMessageReceiver.cpp: (WebKit::TestWithIfMessage::didReceiveMessage): * Source/WebKit/Scripts/webkit/tests/TestWithImageDataMessageReceiver.cpp: (WebKit::TestWithImageData::didReceiveMessage): * Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp: (WebKit::TestWithLegacyReceiver::didReceiveTestWithLegacyReceiverMessage): (WebKit::TestWithLegacyReceiver::didReceiveSyncTestWithLegacyReceiverMessage): * Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessageReceiver.cpp: (WebKit::TestWithSemaphore::didReceiveMessage): * Source/WebKit/Scripts/webkit/tests/TestWithStreamBatchedMessageReceiver.cpp: (WebKit::TestWithStreamBatched::didReceiveStreamMessage): * Source/WebKit/Scripts/webkit/tests/TestWithStreamBufferMessageReceiver.cpp: (WebKit::TestWithStreamBuffer::didReceiveMessage): * Source/WebKit/Scripts/webkit/tests/TestWithStreamMessageReceiver.cpp: (WebKit::TestWithStream::didReceiveStreamMessage): * Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessageReceiver.cpp: (WebKit::TestWithSuperclass::didReceiveSyncMessage): * Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp: (WebKit::TestWithoutAttributes::didReceiveMessage): (WebKit::TestWithoutAttributes::didReceiveSyncMessage): * Source/WebKit/Shared/AuxiliaryProcess.cpp: (WebKit::AuxiliaryProcess::addMessageReceiver): (WebKit::AuxiliaryProcess::removeMessageReceiver): * Source/WebKit/Shared/AuxiliaryProcess.h: * Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp: (WebKit::AuxiliaryProcessProxy::addMessageReceiver): (WebKit::AuxiliaryProcessProxy::removeMessageReceiver): * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: (WebKit::AuxiliaryProcessProxy::send): (WebKit::AuxiliaryProcessProxy::sendSync): (WebKit::AuxiliaryProcessProxy::sendWithAsyncReply): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::addMessageReceiver): (WebKit::WebProcessPool::removeMessageReceiver): * Source/WebKit/UIProcess/WebProcessPool.h: * Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp: (WebKit::evaluateJavaScriptCallback): * Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp: (WebKit::IPCTestingAPI::JSMessageListener::jsDescriptionFromDecoder): * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::didReceiveMessage): * Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp: (TestWebKitAPI::TEST_P): * Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.h: * Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: Canonical link: https://commits.webkit.org/258904@main
webkit-early-warning-system
force-pushed
the
eng/Effectively-revert-258484main
branch
from
January 14, 2023 04:20
81ef599
to
a3ebb42
Compare
Committed 258904@main (a3ebb42): https://commits.webkit.org/258904@main Reviewed commits have been landed. Closing PR #8652 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a3ebb42
81ef599
🛠 🧪 win🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress