Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow IOSurfaces to work with bridge_cast() #8932

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Allow IOSurfaces to work with bridge_cast() #8932

merged 1 commit into from
Jan 22, 2023

Conversation

litherum
Copy link
Contributor

@litherum litherum commented Jan 21, 2023 •
edited by webkit-early-warning-system
Loading

74595db

Allow IOSurfaces to work with bridge_cast()
https://bugs.webkit.org/show_bug.cgi?id=250951
rdar://104516800

Reviewed by Tim Horton.

IOSurfaceRef and IOSurface * are toll-free-bridged.

* Source/WTF/wtf/cocoa/TollFreeBridging.h:

Canonical link: https://commits.webkit.org/259181@main

fc64afe

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 🧪 merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@litherum litherum self-assigned this Jan 21, 2023
@litherum litherum added the Compositing Bugs related to layerization for transforms, video, scrolling etc label Jan 21, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 94e1471)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
❌ 🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
⏳ 🛠 🧪 jsc ❌ 🛠 tv   🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv-sim   🧪 mac-AS-debug-wk2   🧪 jsc-armv7-tests
⏳ 🛠 watch   🧪 mac-wk2-stress ✅ 🛠 jsc-mips
⏳ 🛠 watch-sim   🧪 jsc-mips-tests

@litherum litherum force-pushed the eng/Allow-IOSurfaces-to-work-with-bridge_cast branch from 94e1471 to 8b24a0e Compare January 21, 2023 23:57
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 8b24a0e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
❌ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 🧪 jsc ❌ 🛠 tv   🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ❌ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
❌ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
❌ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 22, 2023
@litherum litherum removed the merging-blocked Applied to prevent a change from being merged label Jan 22, 2023
@litherum litherum force-pushed the eng/Allow-IOSurfaces-to-work-with-bridge_cast branch from 8b24a0e to dabd28c Compare January 22, 2023 02:11
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 22, 2023 •
edited
Loading

EWS run on previous version of this PR (hash dabd28c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac   🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 mac-wk1 ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ❌ 🛠 tv ❌ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ❌ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
❌ 🛠 watch ❌ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
❌ 🛠 watch-sim   🧪 jsc-mips-tests

@litherum litherum mentioned this pull request Jan 22, 2023
Merged
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 22, 2023
@litherum litherum removed the merging-blocked Applied to prevent a change from being merged label Jan 22, 2023
@litherum litherum force-pushed the eng/Allow-IOSurfaces-to-work-with-bridge_cast branch from dabd28c to a205ee6 Compare January 22, 2023 02:33
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 22, 2023 •
edited
Loading

EWS run on previous version of this PR (hash a205ee6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ⏳ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 🧪 win
❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ✅ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 gtk-wk2
❌ 🧪 api-ios ⏳ 🧪 mac-wk1 ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ❌ 🛠 tv ⏳ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
⏳ 🛠 🧪 jsc-arm64 ❌ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
❌ 🛠 watch ⏳ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
❌ 🛠 watch-sim   🧪 jsc-mips-tests

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 22, 2023
@litherum litherum removed the merging-blocked Applied to prevent a change from being merged label Jan 22, 2023
@litherum litherum force-pushed the eng/Allow-IOSurfaces-to-work-with-bridge_cast branch from a205ee6 to 1b0294d Compare January 22, 2023 02:46
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 22, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 22, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 1b0294d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
❌ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
❌ 🛠 🧪 jsc ❌ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ❌ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
❌ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
❌ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@litherum litherum removed the merging-blocked Applied to prevent a change from being merged label Jan 22, 2023
@litherum litherum force-pushed the eng/Allow-IOSurfaces-to-work-with-bridge_cast branch from 1b0294d to fc64afe Compare January 22, 2023 05:54
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 22, 2023 •
edited
Loading

EWS run on current version of this PR (hash fc64afe)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 🧪 merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@litherum litherum added the merge-queue Applied to send a pull request to merge-queue label Jan 22, 2023
@litherum
Allow IOSurfaces to work with bridge_cast()
74595db 
https://bugs.webkit.org/show_bug.cgi?id=250951
rdar://104516800

Reviewed by Tim Horton.

IOSurfaceRef and IOSurface * are toll-free-bridged.

* Source/WTF/wtf/cocoa/TollFreeBridging.h:

Canonical link: https://commits.webkit.org/259181@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Allow-IOSurfaces-to-work-with-bridge_cast branch from fc64afe to 74595db Compare January 22, 2023 08:00
@webkit-commit-queue
Copy link
Collaborator

Committed 259181@main (74595db): https://commits.webkit.org/259181@main

Reviewed commits have been landed. Closing PR #8932 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 74595db into WebKit:main Jan 22, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 22, 2023
@litherum litherum deleted the eng/Allow-IOSurfaces-to-work-with-bridge_cast branch January 22, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@smfr smfr Awaiting requested review from smfr

Assignees

@litherum litherum

Labels
Compositing Bugs related to layerization for transforms, video, scrolling etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@litherum @webkit-early-warning-system @webkit-commit-queue @hortont424 @webkit-ews-buildbot