-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebGPU] Give a ConvertToBackingContext to SurfaceImpl and SwapChainImpl #8942
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
litherum:eng/WebGPU-Give-a-ConvertToBackingContext-to-SurfaceImpl-and-SwapChainImpl
Jan 23, 2023
Merged
[WebGPU] Give a ConvertToBackingContext to SurfaceImpl and SwapChainImpl #8942
webkit-commit-queue
merged 1 commit into
WebKit:main
from
litherum:eng/WebGPU-Give-a-ConvertToBackingContext-to-SurfaceImpl-and-SwapChainImpl
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 8f5d48b) |
litherum
force-pushed
the
eng/WebGPU-Give-a-ConvertToBackingContext-to-SurfaceImpl-and-SwapChainImpl
branch
from
January 22, 2023 07:26
8f5d48b
to
bfb1b1f
Compare
mwyrzykowski
approved these changes
Jan 22, 2023
EWS run on current version of this PR (hash bfb1b1f)
|
kkinnunen-apple
approved these changes
Jan 23, 2023
https://bugs.webkit.org/show_bug.cgi?id=250964 rdar://104522936 Reviewed by Kimmo Kinnunen. SurfaceImpl and SwapChainImpl don't actually need a ConvertToBackingContext right now, but most of the other ***Impl classes need one and have one, so I think it's just generally a good idea to be consistent with the pattern and give one to all the ***Impl classes. In the future, when we're developing, I don't think we should have to remember which classes have a ConvertToBackingContext and which don't. * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.cpp: (PAL::WebGPU::SurfaceImpl::SurfaceImpl): (PAL::WebGPU::SurfaceImpl::setLabelInternal): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.h: * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.cpp: (PAL::WebGPU::SwapChainImpl::SwapChainImpl): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.h: Canonical link: https://commits.webkit.org/259235@main
webkit-commit-queue
force-pushed
the
eng/WebGPU-Give-a-ConvertToBackingContext-to-SurfaceImpl-and-SwapChainImpl
branch
from
January 23, 2023 21:19
bfb1b1f
to
db1acf9
Compare
Committed 259235@main (db1acf9): https://commits.webkit.org/259235@main Reviewed commits have been landed. Closing PR #8942 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Jan 23, 2023
litherum
deleted the
eng/WebGPU-Give-a-ConvertToBackingContext-to-SurfaceImpl-and-SwapChainImpl
branch
January 23, 2023 21:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db1acf9
bfb1b1f