Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebGPU] Give a ConvertToBackingContext to SurfaceImpl and SwapChainImpl #8942

Conversation

litherum
Copy link
Contributor

@litherum litherum commented Jan 22, 2023

db1acf9

[WebGPU] Give a ConvertToBackingContext to SurfaceImpl and SwapChainImpl
https://bugs.webkit.org/show_bug.cgi?id=250964
rdar://104522936

Reviewed by Kimmo Kinnunen.

SurfaceImpl and SwapChainImpl don't actually need a ConvertToBackingContext right now, but
most of the other ***Impl classes need one and have one, so I think it's just generally a
good idea to be consistent with the pattern and give one to all the ***Impl classes. In the
future, when we're developing, I don't think we should have to remember which classes have
a ConvertToBackingContext and which don't.

* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.cpp:
(PAL::WebGPU::SurfaceImpl::SurfaceImpl):
(PAL::WebGPU::SurfaceImpl::setLabelInternal):
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.h:
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.cpp:
(PAL::WebGPU::SwapChainImpl::SwapChainImpl):
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.h:

Canonical link: https://commits.webkit.org/259235@main

bfb1b1f

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@litherum litherum self-assigned this Jan 22, 2023
@litherum litherum added the WebGPU For bugs in WebGPU label Jan 22, 2023
@litherum litherum force-pushed the eng/WebGPU-Give-a-ConvertToBackingContext-to-SurfaceImpl-and-SwapChainImpl branch from 8f5d48b to bfb1b1f Compare January 22, 2023 07:26
@litherum litherum added the merge-queue Applied to send a pull request to merge-queue label Jan 23, 2023
https://bugs.webkit.org/show_bug.cgi?id=250964
rdar://104522936

Reviewed by Kimmo Kinnunen.

SurfaceImpl and SwapChainImpl don't actually need a ConvertToBackingContext right now, but
most of the other ***Impl classes need one and have one, so I think it's just generally a
good idea to be consistent with the pattern and give one to all the ***Impl classes. In the
future, when we're developing, I don't think we should have to remember which classes have
a ConvertToBackingContext and which don't.

* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.cpp:
(PAL::WebGPU::SurfaceImpl::SurfaceImpl):
(PAL::WebGPU::SurfaceImpl::setLabelInternal):
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSurfaceImpl.h:
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.cpp:
(PAL::WebGPU::SwapChainImpl::SwapChainImpl):
* Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUSwapChainImpl.h:

Canonical link: https://commits.webkit.org/259235@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-Give-a-ConvertToBackingContext-to-SurfaceImpl-and-SwapChainImpl branch from bfb1b1f to db1acf9 Compare January 23, 2023 21:19
@webkit-commit-queue
Copy link
Collaborator

Committed 259235@main (db1acf9): https://commits.webkit.org/259235@main

Reviewed commits have been landed. Closing PR #8942 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit db1acf9 into WebKit:main Jan 23, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 23, 2023
@litherum litherum deleted the eng/WebGPU-Give-a-ConvertToBackingContext-to-SurfaceImpl-and-SwapChainImpl branch January 23, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
5 participants