Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RealtimeOutgoingVideoSourceCocoa pixelBufferPool should use video range #909

Merged
merged 0 commits into from May 23, 2022
Merged

RealtimeOutgoingVideoSourceCocoa pixelBufferPool should use video range #909

merged 0 commits into from May 23, 2022

Conversation

youennf
Copy link
Contributor

@youennf youennf commented May 23, 2022 •
edited by webkit-early-warning-system

897e10e

RealtimeOutgoingVideoSourceCocoa pixelBufferPool should use video range
https://bugs.webkit.org/show_bug.cgi?id=240463
rdar://problem/93354226

Patch by Youenn Fablet <youennf@gmail.com > on 2022-05-23
Reviewed by Eric Carlson.

We switched to using a pixel conformer that was using preferredPixelFormat to using libyuv routine.
Update the pixel buffer pool to use kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange to be compliant with libyuv routines.

* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
(WebCore::RealtimeOutgoingVideoSourceCocoa::pixelBufferPool):

Canonical link: https://commits.webkit.org/250861@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@youennf youennf added the WebRTC For bugs in WebRTC label May 23, 2022
@youennf youennf requested a review from eric-carlson May 23, 2022 11:17
@youennf youennf self-assigned this May 23, 2022
@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label May 23, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/RealtimeOutgoingVideoSourceCocoa-pixelBufferPool-should-use-video-range branch from ed4a844 to 897e10e Compare May 23, 2022 13:38
@webkit-early-warning-system webkit-early-warning-system merged commit 897e10e into WebKit:main May 23, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294637 (250861@main): https://commits.webkit.org/250861@main

Reviewed commits have been landed. Closing PR #909 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-carlson eric-carlson eric-carlson approved these changes

Assignees

@youennf youennf

Labels
WebRTC For bugs in WebRTC
Projects
None yet
Milestone
No milestone
3 participants
@youennf @webkit-early-warning-system @eric-carlson