Regression: [ews] check-status-on-other-ewses step is not working #9182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Tools / Tests
|
EWS run on previous version of this PR (hash a59a70a)
|
aj062
reviewed
Jan 26, 2023
Tools/CISupport/ews-build/steps.py
Outdated
| self._addToLog('stdio', 'Failed to access {}\n'.format(url)) | ||
| except Exception as e: | ||
| yield self._addToLog('stdio', 'Failed to access {}\n'.format(url)) | ||
| yield self._addToLog('stdio', ' {}\n'.format(str(e))) |
There was a problem hiding this comment.
these two log lines can be combined in one. Also can use python 3 f-strings.
aj062
reviewed
Jan 26, 2023
| @@ -5004,16 +5004,17 @@ def get_change_status(self, change_id, queue): | |||
| try: | |||
| response = yield TwistedAdditions.request(url, logger=lambda content: self._addToLog('stdio', content)) | |||
| if response.status_code != 200: | |||
There was a problem hiding this comment.
but why was response.status_code non-200 in the first place?
There was a problem hiding this comment.
That's not the case we're hitting, we're hitting the Exception
aj062
approved these changes
Jan 26, 2023
JonWBedard
force-pushed
the
eng/Regression-ews-check-status-on-other-ewses-step-is-not-working
branch
from
a59a70a
to
dbb0e34
Compare
|
EWS run on current version of this PR (hash dbb0e34)
|
|
To be clear, this PR is intended to shed light on the situation, not fix the problem. We can't reproduce this problem on our staging instance and are hoping logging can help narrow the issue now. |
JonWBedard
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=251214 rdar://104701249 Reviewed by Aakash Jain. Add logging to the code from 259315@main to log the raised exception. * Tools/CISupport/ews-build/steps.py: (CheckStatusOnEWSQueues.get_change_status): Canonical link: https://commits.webkit.org/259438@main
webkit-early-warning-system
force-pushed
the
eng/Regression-ews-check-status-on-other-ewses-step-is-not-working
branch
from
dbb0e34
to
18d5a67
Compare
|
Committed 259438@main (18d5a67): https://commits.webkit.org/259438@main Reviewed commits have been landed. Closing PR #9182 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
JonWBedard
deleted the
eng/Regression-ews-check-status-on-other-ewses-step-is-not-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
18d5a67
dbb0e34
🛠 mac🛠 wpe🛠 🧪 win🛠 gtk🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 tv🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim