Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION (250413@main): [ iOS ] system-preview/badge.html is a consistent image failure #929

Merged
merged 0 commits into from May 24, 2022
Merged

REGRESSION (250413@main): [ iOS ] system-preview/badge.html is a consistent image failure #929

merged 0 commits into from May 24, 2022

Conversation

graouts
Copy link
Contributor

@graouts graouts commented May 23, 2022 •
edited by webkit-early-warning-system

e546019

REGRESSION (250413@main): [ iOS ] system-preview/badge.html is a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=240352
rdar://93191053

Patch by Antoine Quint <graouts@apple.com > on 2022-05-23
Reviewed by Simon Fraser.

In the case of an ARKit image, we should only be returning when we don't
have a native image to record, otherwise the system image itself needs
to be recorded as well.

* LayoutTests/platform/ios-wk2/TestExpectations:
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawSystemImage):

Canonical link: https://commits.webkit.org/250907@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@graouts graouts self-assigned this May 23, 2022
@graouts graouts added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels May 23, 2022
@graouts graouts force-pushed the display-list-recorder-regression branch from c4814a8 to a2e56d3 Compare May 23, 2022 19:30
@graouts graouts requested a review from smfr May 23, 2022 19:31
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 23, 2022
@graouts graouts added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels May 24, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit e546019 into WebKit:main May 24, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294729 (250907@main): https://commits.webkit.org/250907@main

Reviewed commits have been landed. Closing PR #929 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 24, 2022
@graouts graouts deleted the display-list-recorder-regression branch May 24, 2022 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

Assignees

@graouts graouts

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
3 participants
@graouts @webkit-early-warning-system @smfr