[ews-build.webkit.org] Convert SetCommitQueueMinusFlagOnPatch to Twisted asynchronous requests #9317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Tools / Tests
aj062
approved these changes
Jan 30, 2023
| def set_cq_minus_flag_on_patch(self, patch_id): | ||
| patch_url = '{}rest/bug/attachment/{}'.format(BUG_SERVER_URL, patch_id) |
There was a problem hiding this comment.
might be good to keep the URL is explicit variable (like before) for maintainability.
|
EWS run on previous version of this PR (hash f7ecac8)
|
🧪 webkitperl
JonWBedard
force-pushed
the
eng/251294
branch
from
f7ecac8
to
709a90c
Compare
|
EWS run on previous version of this PR (hash 709a90c)
|
JonWBedard
force-pushed
the
eng/251294
branch
from
709a90c
to
80af614
Compare
JonWBedard
added
the
unsafe-merge-queue
|
EWS run on current version of this PR (hash 80af614)
|
…ted asynchronous requests https://bugs.webkit.org/show_bug.cgi?id=251294 rdar://104761643 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/steps.py: (BugzillaMixin.set_cq_minus_flag_on_patch): Convert to Twisted asynchronous requests. (SetCommitQueueMinusFlagOnPatch.run): Renamed from start. (SetCommitQueueMinusFlagOnPatch.start): Renamed to run. Canonical link: https://commits.webkit.org/259729@main
webkit-early-warning-system
force-pushed
the
eng/251294
branch
from
80af614
to
3465693
Compare
|
Committed 259729@main (3465693): https://commits.webkit.org/259729@main Reviewed commits have been landed. Closing PR #9317 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3465693
80af614
🧪 style🛠 ios🛠 mac🛠 wpe🛠 🧪 win🧪 bindings🛠 ios-sim🛠 mac-AS-debug🛠 gtk🛠 wincairo🧪 webkitperl🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 tv🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim