Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Inspector: Network Table: activity is not marked as a previous session when the Network Tab is not selected #955

Merged
merged 0 commits into from May 24, 2022

Conversation

dcrousso
Copy link
Member

@dcrousso dcrousso commented May 24, 2022

3e38a86

Web Inspector: Network Table: activity is not marked as a previous session when the Network Tab is not selected
https://bugs.webkit.org/show_bug.cgi?id=240846

Reviewed by Patrick Angle.

* Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._mainResourceDidChange):
(WI.NetworkTableContentView.prototype._entryForResource):
Also mark `WI.Resource` that haven't yet been inserted into the `WI.Table` when navigating the main
resource. Use this when generating an entry for that `WI.Resource` for the first time, instead of
always assuming that the `WI.Resource` is part of the current session.

Canonical link: https://commits.webkit.org/250902@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@dcrousso dcrousso self-assigned this May 24, 2022
@dcrousso dcrousso added Web Inspector Bugs related to the WebKit Web Inspector. WebKit Nightly Build labels May 24, 2022
@dcrousso dcrousso added the merge-queue Applied to send a pull request to merge-queue label May 24, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 3e38a86 into WebKit:main May 24, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294716 (250902@main): https://commits.webkit.org/250902@main

Reviewed commits have been landed. Closing PR #955 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 24, 2022
@dcrousso dcrousso deleted the eng/240846 branch May 24, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
3 participants