Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<attachment> should get an interaction region #9573

Merged
merged 1 commit into from
Feb 3, 2023
Merged

<attachment> should get an interaction region #9573

merged 1 commit into from
Feb 3, 2023

Conversation

hortont424
Copy link
Contributor

@hortont424 hortont424 commented Feb 3, 2023 •
edited by webkit-early-warning-system

@hortont424 hortont424 self-assigned this Feb 3, 2023
@hortont424 hortont424 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Feb 3, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 82ebeaa)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ❌ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 gtk-wk2
  🧪 api-ios ⏳ 🧪 mac-wk1 ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ⏳ 🛠 tv ⏳ 🧪 mac-wk2
⏳ 🛠 tv-sim ⏳ 🧪 mac-AS-debug-wk2
⏳ 🛠 watch ⏳ 🧪 mac-wk2-stress
⏳ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 3, 2023
@hortont424 hortont424 removed the merging-blocked Applied to prevent a change from being merged label Feb 3, 2023
@hortont424 hortont424 force-pushed the eng/attachment-should-get-an-interaction-region branch from 82ebeaa to 3e9653e Compare February 3, 2023 02:48
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 3e9653e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim   🛠 mac-AS-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
  🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge   🛠 watch-sim

@hortont424 hortont424 added the merge-queue Applied to send a pull request to merge-queue label Feb 3, 2023
@hortont424
<attachment> should get an interaction region
b24ce8d 
https://bugs.webkit.org/show_bug.cgi?id=251654
rdar://104976178

Reviewed by Wenson Hsieh.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::shouldAllowNonPointerCursorForElement):

Canonical link: https://commits.webkit.org/259799@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/attachment-should-get-an-interaction-region branch from 3e9653e to b24ce8d Compare February 3, 2023 05:07
@webkit-commit-queue
Copy link
Collaborator

Committed 259799@main (b24ce8d): https://commits.webkit.org/259799@main

Reviewed commits have been landed. Closing PR #9573 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b24ce8d into WebKit:main Feb 3, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@megangardner megangardner Awaiting requested review from megangardner

@grorg grorg Awaiting requested review from grorg

Assignees

@hortont424 hortont424

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
5 participants
@hortont424 @webkit-early-warning-system @webkit-commit-queue @whsieh @webkit-ews-buildbot