Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address flaky test case scroll-into-view-and-show-validation-message.html when run using WK1 #977

Merged

Conversation

stwrt
Copy link
Member

@stwrt stwrt commented May 24, 2022

06b95d5

Address flaky test case scroll-into-view-and-show-validation-message.html when run using WK1
https://bugs.webkit.org/show_bug.cgi?id=240875

Reviewed by Wenson Hsieh.

Address failing test case fast/forms/scroll-into-view-and-show-validation-message.html
when run using WK1. This test only fails when running WK1 and only when run
in parallel.

* LayoutTests/fast/forms/textarea-scrolled-endline-caret.html:
* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/250998@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@stwrt stwrt self-assigned this May 24, 2022
@stwrt stwrt added Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) Other labels May 24, 2022
@stwrt stwrt requested review from whsieh and rniwa May 24, 2022 16:17
Comment on lines 23 to 32
setTimeout(function() {
eventSender.mouseMoveTo(90, 20);
eventSender.mouseDown();
eventSender.mouseUp();
if (ta.selectionEnd == 17)
res.innerHTML = "Test Succeeded";
else
res.innerHTML = "Test Failed: caret is at " + ta.selectionEnd;
testRunner.notifyDone();
}, 0);
Copy link
Member

@whsieh whsieh May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems what you're waiting for here is the next rendering update?

There's a helper method, UIHelper.renderingUpdate(), in ui-helper.js that you might find useful here:

UIHelper.renderingUpdate().then(() => {
    eventSender.mouseMoveTo(90, 20);
    eventSender.mouseDown();
    eventSender.mouseUp();
    if (ta.selectionEnd == 17)
        res.innerHTML = "Test Succeeded";
    else
        res.innerHTML = "Test Failed: caret is at " + ta.selectionEnd;
    testRunner.notifyDone();
});

(or, if you want to make this an async function):

await UIHelper.renderingUpdate();
eventSender.mouseMoveTo(90, 20);
eventSender.mouseDown();
eventSender.mouseUp();
if (ta.selectionEnd == 17)
    res.innerHTML = "Test Succeeded";
else
    res.innerHTML = "Test Failed: caret is at " + ta.selectionEnd;
testRunner.notifyDone();

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll take a look into this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stwrt stwrt added the merging-blocked Applied to prevent a change from being merged label May 24, 2022
@stwrt stwrt force-pushed the eng/address_failing_tests branch from bda0fd6 to 3260728 Compare May 26, 2022 02:59
@stwrt stwrt removed merging-blocked Applied to prevent a change from being merged Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) Other labels May 26, 2022
@stwrt stwrt changed the title Address Failing Test Cases in WK1 Address flaky test case scroll-into-view-and-show-validation-message.html when run using WK1 May 26, 2022
@stwrt stwrt added Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) Other merge-queue Applied to send a pull request to merge-queue labels May 26, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 06b95d5 into WebKit:main May 26, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294868 (250998@main): https://commits.webkit.org/250998@main

Reviewed commits have been landed. Closing PR #977 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 26, 2022
@stwrt stwrt deleted the eng/address_failing_tests branch July 1, 2022 22:49
eocanha pushed a commit to eocanha/WebKit that referenced this pull request Feb 8, 2023
…i/2.38/relax_user_agent_validation

Relax user agent validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.)
Projects
None yet
3 participants