Enable 'immediate-output' on streaming through westerossink #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modeveci
approved these changes
Aug 3, 2023
eocanha
added
wpe-2.38
upstream
|
Patch submitted upstream for review as https://bugs.webkit.org/show_bug.cgi?id=259930 / WebKit/WebKit#16479 |
webkit-commit-queue
pushed a commit
to eocanha/WebKit
that referenced
this pull request
Aug 9, 2023
…ming through westerossink https://bugs.webkit.org/show_bug.cgi?id=259930 Reviewed by Philippe Normand. https://bugs.webkit.org/show_bug.cgi?id=259357 removed the configuration of the "immediate-output" property for westeros sink, but it's still needed for mediastream content. Original author: Vivek.A <Vivek_Arumugam@comcast.com> See: WebPlatformForEmbedded/WPEWebKit#1136 * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElementPlatformQuirks): Configure the immediate-output property for westerossink. Canonical link: https://commits.webkit.org/266720@main
eocanha
added a commit
that referenced
this pull request
Aug 9, 2023
…ming through westerossink https://bugs.webkit.org/show_bug.cgi?id=259930 Reviewed by Philippe Normand. https://bugs.webkit.org/show_bug.cgi?id=259357 removed the configuration of the "immediate-output" property for westeros sink, but it's still needed for mediastream content. Original author: Vivek.A <Vivek_Arumugam@comcast.com> See: #1136 * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElementPlatformQuirks): Configure the immediate-output property for westerossink. Canonical link: https://commits.webkit.org/266720@main
|
Patch backported to https://github.com/WebPlatformForEmbedded/WPEWebKit/tree/wpe-2.38 as a4751cc, closing PR. |
carlosgcampos
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Aug 18, 2023
…gi?id=259930 [GStreamer][MediaStream][Westeros] Enable 'immediate-output' on streaming through westerossink https://bugs.webkit.org/show_bug.cgi?id=259930 Reviewed by Philippe Normand. https://bugs.webkit.org/show_bug.cgi?id=259357 removed the configuration of the "immediate-output" property for westeros sink, but it's still needed for mediastream content. Original author: Vivek.A <Vivek_Arumugam@comcast.com> See: WebPlatformForEmbedded/WPEWebKit#1136 * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElementPlatformQuirks): Configure the immediate-output property for westerossink. Canonical link: https://commits.webkit.org/266720@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings back (part of) the change originally made in f9377b1 but removed inadvertently by 0035d13